why was this pushed?

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

why was this pushed?

James Lowe-7
Added vowel transitions for lyrics master staging
author    David Stephen Grant <[hidden email]>
     Wed, 25 Mar 2020 09:27:43 +0000 (10:27 +0100)
committer    Han-Wen Nienhuys <[hidden email]>
     Wed, 25 Mar 2020 09:27:43 +0000 (10:27 +0100)
commit    b7034e683d47b1e9bb11e5464a7e514912a0d9ba

---

I don't see any where that it was OK to do so.

James




Reply | Threaded
Open this post in threaded view
|

Re: why was this pushed?

Han-Wen Nienhuys-3
This was marked as Countdown in your Monday mail.

On Wed, Mar 25, 2020 at 5:55 PM James Lowe <[hidden email]> wrote:

>
> Added vowel transitions for lyrics master staging
> author    David Stephen Grant <[hidden email]>
>      Wed, 25 Mar 2020 09:27:43 +0000 (10:27 +0100)
> committer    Han-Wen Nienhuys <[hidden email]>
>      Wed, 25 Mar 2020 09:27:43 +0000 (10:27 +0100)
> commit    b7034e683d47b1e9bb11e5464a7e514912a0d9ba
>
> ---
>
> I don't see any where that it was OK to do so.
>
> James
>
>
>


--
Han-Wen Nienhuys - [hidden email] - http://www.xs4all.nl/~hanwen

Reply | Threaded
Open this post in threaded view
|

Re: why was this pushed?

Carl Sorensen-3
We don't push until the status becomes Push.  Countdown is a last  chance for reviewers to comment.

Thanks,

Carl


On 3/25/20, 12:06 PM, "lilypond-devel on behalf of Han-Wen Nienhuys" <lilypond-devel-bounces+c_sorensen=[hidden email] on behalf of [hidden email]> wrote:

    This was marked as Countdown in your Monday mail.
   
    On Wed, Mar 25, 2020 at 5:55 PM James Lowe <[hidden email]> wrote:
    >
    > Added vowel transitions for lyrics master staging
    > author    David Stephen Grant <[hidden email]>
    >      Wed, 25 Mar 2020 09:27:43 +0000 (10:27 +0100)
    > committer    Han-Wen Nienhuys <[hidden email]>
    >      Wed, 25 Mar 2020 09:27:43 +0000 (10:27 +0100)
    > commit    b7034e683d47b1e9bb11e5464a7e514912a0d9ba
    >
    > ---
    >
    > I don't see any where that it was OK to do so.
    >
    > James
    >
    >
    >
   
   
    --
    Han-Wen Nienhuys - [hidden email] - http://www.xs4all.nl/~hanwen
   
   

Reply | Threaded
Open this post in threaded view
|

Re: why was this pushed?

Han-Wen Nienhuys-3
On Wed, Mar 25, 2020 at 7:40 PM Carl Sorensen <[hidden email]> wrote:
>
> We don't push until the status becomes Push.  Countdown is a last  chance for reviewers to comment.

Sorry, I saw Valentin had pushed his, so I assumed this was OK.

Note that it was marked countdown for push by today.

> Thanks,
>
> Carl
>
>
> On 3/25/20, 12:06 PM, "lilypond-devel on behalf of Han-Wen Nienhuys" <lilypond-devel-bounces+c_sorensen=[hidden email] on behalf of [hidden email]> wrote:
>
>     This was marked as Countdown in your Monday mail.
>
>     On Wed, Mar 25, 2020 at 5:55 PM James Lowe <[hidden email]> wrote:
>     >
>     > Added vowel transitions for lyrics master staging
>     > author    David Stephen Grant <[hidden email]>
>     >      Wed, 25 Mar 2020 09:27:43 +0000 (10:27 +0100)
>     > committer    Han-Wen Nienhuys <[hidden email]>
>     >      Wed, 25 Mar 2020 09:27:43 +0000 (10:27 +0100)
>     > commit    b7034e683d47b1e9bb11e5464a7e514912a0d9ba
>     >
>     > ---
>     >
>     > I don't see any where that it was OK to do so.
>     >
>     > James
>     >
>     >
>     >
>
>
>     --
>     Han-Wen Nienhuys - [hidden email] - http://www.xs4all.nl/~hanwen
>
>
>


--
Han-Wen Nienhuys - [hidden email] - http://www.xs4all.nl/~hanwen

Reply | Threaded
Open this post in threaded view
|

Re: why was this pushed?

David Kastrup
Han-Wen Nienhuys <[hidden email]> writes:

> On Wed, Mar 25, 2020 at 7:40 PM Carl Sorensen <[hidden email]> wrote:
>>
>> We don't push until the status becomes Push.  Countdown is a last
>> chance for reviewers to comment.
>
> Sorry, I saw Valentin had pushed his, so I assumed this was OK.

But it was an issue by someone else.  Pushing changes of someone else
prematurely when they have not explicitly asked for it bereaves even the
original author of the ability to reconsider.

It's somewhat different taking that responsibility for changes by
oneself in circumstances warranting expedited action (like when other
important changes depend on it).

But doing so without updating issue status and without giving some
feedback with regard to the reasons for urgency is, if nothing else,
quite impolite towards the people who have to pick up the bits
afterwards and sort them into place.

--
David Kastrup

Reply | Threaded
Open this post in threaded view
|

Re: why was this pushed?

pkx166h-4
Hello

On 25/03/2020 19:15, David Kastrup wrote:

> Han-Wen Nienhuys <[hidden email]> writes:
>
>> On Wed, Mar 25, 2020 at 7:40 PM Carl Sorensen <[hidden email]> wrote:
>>> We don't push until the status becomes Push.  Countdown is a last
>>> chance for reviewers to comment.
>> Sorry, I saw Valentin had pushed his, so I assumed this was OK.
> But it was an issue by someone else.  Pushing changes of someone else
> prematurely when they have not explicitly asked for it bereaves even the
> original author of the ability to reconsider.
>
> It's somewhat different taking that responsibility for changes by
> oneself in circumstances warranting expedited action (like when other
> important changes depend on it).
>
> But doing so without updating issue status and without giving some
> feedback with regard to the reasons for urgency is, if nothing else,
> quite impolite towards the people who have to pick up the bits
> afterwards and sort them into place.

I am sure Han-Wen's patches are OK (although I don't personally review
code so other Devs may have wanted to comment), and the one for David
was also evidently not broken - although there was at least one
additional change he made (maybe two) as I discovered this while testing
his 'updated' patch.

If we;re leaving master 'as is', then David will need to figure out the
difference between what was checked in and his latest set of patches and
maybe create a new Rietveld?

Or we could just revert the commit

--

Added vowel transitions for lyrics
author    David Stephen Grant <[hidden email]>
     Wed, 25 Mar 2020 09:27:43 +0000 (10:27 +0100)
committer    Han-Wen Nienhuys <[hidden email]>
     Wed, 25 Mar 2020 09:27:43 +0000 (10:27 +0100)
commit    b7034e683d47b1e9bb11e5464a7e514912a0d9ba

--

and continue as before (David would still need to rebase though).

Let me know and I'll update the Tracker accordingly.

James




Reply | Threaded
Open this post in threaded view
|

Re: why was this pushed?

Han-Wen Nienhuys-3
In reply to this post by David Kastrup
On Wed, Mar 25, 2020 at 8:15 PM David Kastrup <[hidden email]> wrote:
> >> We don't push until the status becomes Push.  Countdown is a last
> >> chance for reviewers to comment.
> >
> > Sorry, I saw Valentin had pushed his, so I assumed this was OK.
>
> But it was an issue by someone else.  Pushing changes of someone else
> prematurely when they have not explicitly asked for it bereaves even the
> original author of the ability to reconsider.

?

David Grant doesn't have push access; there is no circumstance under
which he would push this change himself.

--
Han-Wen Nienhuys - [hidden email] - http://www.xs4all.nl/~hanwen

Reply | Threaded
Open this post in threaded view
|

Re: why was this pushed?

David Kastrup
Han-Wen Nienhuys <[hidden email]> writes:

> On Wed, Mar 25, 2020 at 8:15 PM David Kastrup <[hidden email]> wrote:
>> >> We don't push until the status becomes Push.  Countdown is a last
>> >> chance for reviewers to comment.
>> >
>> > Sorry, I saw Valentin had pushed his, so I assumed this was OK.
>>
>> But it was an issue by someone else.  Pushing changes of someone else
>> prematurely when they have not explicitly asked for it bereaves even the
>> original author of the ability to reconsider.
>
> ?
>
> David Grant doesn't have push access; there is no circumstance under
> which he would push this change himself.

That's why I wrote: "when they have not explicitly asked for it".  It is
not only the repository server you can explicitly ask for such actions,
we have responsive humans as well.

Contributors without push access are usually asked for a git-formatted
patch by the Patch meister when he sets the final "push" state on a
patch.  This makes sure that both patch content and commit message
accurately reflect what the contributor intends to end up in the
repository.  Such last-minute polishings are frequent enough that we
don't push Rietveld patches to master but have a separate staging branch
where the final authoritive tests are being performed.

--
David Kastrup
My replies have a tendency to cause friction.  To help mitigating
damage, feel free to forward problematic posts to me adding a subject
like "timeout 1d" (for a suggested timeout of 1 day) or "offensive".