shepherd a patch?

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

shepherd a patch?

David Nalesnik
Hi all,

I have a patch which implements measure-attached spanners.  I am
having a devil of a time getting the patch up for review.  I simply
can't get git-cl to upload it.  (I suspect this has something to do
with the number of files it touches--my system times out before
everything can be uploaded.)

Would someone be willing to shepherd the patch for me?

Attached is a PNG which shows the output of one of the regtests.

This would _really_ be appreciated.  Thanks!

David

measure-spanner-spacing-pair.png (46K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

Urs Liska-3
Hi David,

I feel responsible for this because I know where this is coming from  ;-)

You can send me the patch. However, it's a long time since I uploaded
anything, so I'm not sure my set-up still works. But I'll try.

Best
Urs

Am 15.11.19 um 04:10 schrieb David Nalesnik:

> Hi all,
>
> I have a patch which implements measure-attached spanners.  I am
> having a devil of a time getting the patch up for review.  I simply
> can't get git-cl to upload it.  (I suspect this has something to do
> with the number of files it touches--my system times out before
> everything can be uploaded.)
>
> Would someone be willing to shepherd the patch for me?
>
> Attached is a PNG which shows the output of one of the regtests.
>
> This would _really_ be appreciated.  Thanks!
>
> David

Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

Dev mailing list
In reply to this post by David Nalesnik
Hi David,

Am Donnerstag, den 14.11.2019, 21:10 -0600 schrieb David Nalesnik:
> Hi all,
>
> I have a patch which implements measure-attached spanners.  I am
> having a devil of a time getting the patch up for review.  I simply
> can't get git-cl to upload it.  (I suspect this has something to do
> with the number of files it touches--my system times out before
> everything can be uploaded.)

based on your other messages, you're using LilyDev when running git-cl?
If you say it times out, I would guess that git-cl waiting for you to
authorize the tool. Usually, it opens a browser for that, but that's
probably not going to work under a headless VM / container?
Did you try running git-cl from your host system?

Jonas

signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

James Lowe-3
In reply to this post by Urs Liska-3
David et al.

On Fri, 15 Nov 2019 07:33:01 +0100, Urs Liska <[hidden email]> wrote:

> Hi David,
>
> I feel responsible for this because I know where this is coming from  ;-)
>
> You can send me the patch. However, it's a long time since I uploaded
> anything, so I'm not sure my set-up still works. But I'll try.
>
> Best
> Urs
>
> Am 15.11.19 um 04:10 schrieb David Nalesnik:
> > Hi all,
> >
> > I have a patch which implements measure-attached spanners.  I am
> > having a devil of a time getting the patch up for review.  I simply
> > can't get git-cl to upload it.  (I suspect this has something to do
> > with the number of files it touches--my system times out before
> > everything can be uploaded.)
> >
> > Would someone be willing to shepherd the patch for me?
> >
> > Attached is a PNG which shows the output of one of the regtests.
> >
> > This would _really_ be appreciated.  Thanks!
> >
> > David

What I would suggest (generally to anyone on this list that ever needs a patch shepherding) is to make sure a tracker exists - @David, as I know you have access to create tickets you can at least do this - and then attach your patch to that and set the tracker to 'started' so that at the very least if (for example) Urs forgets, goes on holiday, has some emergency, that I can at least pick it up/detect it on the countdown and put it up for review myself.

I do this all the time for 'drive by' patches.

James


Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

Federico Bruni-2
In reply to this post by Dev mailing list


Il giorno ven 15 nov 2019 alle 09:19, Jonas Hahnfeld via Discussions on
LilyPond development <[hidden email]> ha scritto:

> Hi David,
>
> Am Donnerstag, den 14.11.2019, 21:10 -0600 schrieb David Nalesnik:
>>  Hi all,
>>
>>  I have a patch which implements measure-attached spanners.  I am
>>  having a devil of a time getting the patch up for review.  I simply
>>  can't get git-cl to upload it.  (I suspect this has something to do
>>  with the number of files it touches--my system times out before
>>  everything can be uploaded.)
>
> based on your other messages, you're using LilyDev when running
> git-cl?
> If you say it times out, I would guess that git-cl waiting for you to
> authorize the tool. Usually, it opens a browser for that, but that's
> probably not going to work under a headless VM / container?
> Did you try running git-cl from your host system?
>

This is what's recommended in the README:
https://github.com/fedelibre/LilyDev/tree/master/mkosi#running-graphical-applications-from-the-container




Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

David Nalesnik
In reply to this post by Dev mailing list
On Fri, Nov 15, 2019 at 2:19 AM Jonas Hahnfeld <[hidden email]> wrote:

>
> Hi David,
>
> Am Donnerstag, den 14.11.2019, 21:10 -0600 schrieb David Nalesnik:
>
> Hi all,
>
>
> I have a patch which implements measure-attached spanners.  I am
>
> having a devil of a time getting the patch up for review.  I simply
>
> can't get git-cl to upload it.  (I suspect this has something to do
>
> with the number of files it touches--my system times out before
>
> everything can be uploaded.)
>
>
> based on your other messages, you're using LilyDev when running git-cl? If you say it times out, I would guess that git-cl waiting for you to authorize the tool. Usually, it opens a browser for that, but that's probably not going to work under a headless VM / container?
> Did you try running git-cl from your host system?
>
> Jonas

Ugh.  My failing memory.  Several years ago I did need to upload the
patch from git-cl on an Ubuntu machine outside of LilyDev.  The output
I got on the Win10 machine that hosts LilyDev would give me output
similar to the following:

[dev@lilydev:lilypond-git]$ git-cl upload origin/master
 input/regression/measure-spanner-spacing-pair.ly |  33 +++++
 input/regression/measure-spanner.ly              |  30 +++++
 lily/bracket.cc                                  |  10 +-
 lily/enclosing-bracket.cc                        |   4 +-
 lily/include/bracket.hh                          |   3 +-
 lily/include/measure-attached-spanner.hh         |  34 +++++
 lily/measure-attached-spanner.cc                 | 151 +++++++++++++++++++++++
 ly/spanners-init.ly                              |   4 +
 scm/define-event-classes.scm                     |   1 +
 scm/define-grobs.scm                             |  22 ++++
 scm/define-music-types.scm                       |   6 +
 scm/scheme-engravers.scm                         |  63 ++++++++++
 12 files changed, 353 insertions(+), 8 deletions(-)
Upload server: codereview.appspot.com (change with -s/--server)
Your browser has been opened to visit:

    https://codereview.appspot.com/get-access-token?port=8001

If your browser is on a different machine then exit and re-run
upload.py with the command-line parameter

  --no_oauth2_webbrowser

Issue created. URL: http://codereview.appspot.com/566970043
Uploading base file for input/regression/measure-spanner-spacing-pair.ly
Uploading base file for scm/define-event-classes.scm
Uploading base file for scm/scheme-engravers.scm
Uploading base file for scm/define-grobs.scm
Traceback (most recent call last):
  File "/home/dev/git-cl/git-cl", line 628, in <module>
    sys.exit(main(sys.argv))
  File "/home/dev/git-cl/git-cl", line 622, in main
    return func(argv[2:])
  File "/home/dev/git-cl/git-cl", line 335, in CmdUpload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File "/home/dev/git-cl/upload.py", line 2693, in RealMain
    vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, files)
  File "/home/dev/git-cl/upload.py", line 1220, in UploadBaseFiles
    print t.get(timeout=60)
  File "/usr/lib/python2.7/multiprocessing/pool.py", line 567, in get
    raise self._value
urllib2.URLError: <urlopen error [Errno -3] Temporary failure in name
resolution>
[dev@lilydev:lilypond-git]$

----------------------------------------------

I see now that a Rietveld issue is created with all my changes present.
https://codereview.appspot.com/571180043/
However, no issue is created on the Allura tracker.

I presume that it is possible to do what remains in the issue tracker
without having to run git-cl successfully?

Thanks for your help!
David

Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

David Nalesnik
In reply to this post by James Lowe-3
On Fri, Nov 15, 2019 at 4:31 AM James Lowe <[hidden email]> wrote:

>
> David et al.
>
> On Fri, 15 Nov 2019 07:33:01 +0100, Urs Liska <[hidden email]> wrote:
>
> > Hi David,
> >
> > I feel responsible for this because I know where this is coming from  ;-)
> >
> > You can send me the patch. However, it's a long time since I uploaded
> > anything, so I'm not sure my set-up still works. But I'll try.
> >
> > Best
> > Urs
> >
> > Am 15.11.19 um 04:10 schrieb David Nalesnik:
> > > Hi all,
> > >
> > > I have a patch which implements measure-attached spanners.  I am
> > > having a devil of a time getting the patch up for review.  I simply
> > > can't get git-cl to upload it.  (I suspect this has something to do
> > > with the number of files it touches--my system times out before
> > > everything can be uploaded.)
> > >
> > > Would someone be willing to shepherd the patch for me?
> > >
> > > Attached is a PNG which shows the output of one of the regtests.
> > >
> > > This would _really_ be appreciated.  Thanks!
> > >
> > > David
>
> What I would suggest (generally to anyone on this list that ever needs a patch shepherding) is to make sure a tracker exists - @David, as I know you have access to create tickets you can at least do this - and then attach your patch to that and set the tracker to 'started' so that at the very least if (for example) Urs forgets, goes on holiday, has some emergency, that I can at least pick it up/detect it on the countdown and put it up for review myself.
>
> I do this all the time for 'drive by' patches.
>
> James
>

Thanks for this explanation.  I discovered that my patch had gone to
Rietveld, only no ticket was created.  So the error has to do with the
issue tracker.  Here's hoping that it's possible to do what's left
manually without too much trouble!

Best,
David

Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

David Nalesnik
In reply to this post by Urs Liska-3
On Fri, Nov 15, 2019 at 12:33 AM Urs Liska <[hidden email]> wrote:
>
> Hi David,
>
> I feel responsible for this because I know where this is coming from  ;-)

Hah! :)  (Seriously, though, this is something that I've wanted and
Kieren has clamored for...)

>
> You can send me the patch. However, it's a long time since I uploaded
> anything, so I'm not sure my set-up still works. But I'll try.
>
> Best
> Urs

I appreciate this very much!  Turns out, I may be able to do this
manually.  (A Rietveld issue is
created--https://codereview.appspot.com/571180043/  just no tracker
issue.)

I will let you know!

David

Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

David Nalesnik
In reply to this post by Federico Bruni-2
Federico,

On Fri, Nov 15, 2019 at 6:39 AM Federico Bruni <[hidden email]> wrote:

>
> This is what's recommended in the README:
> https://github.com/fedelibre/LilyDev/tree/master/mkosi#running-graphical-applications-from-the-container
>

I saw this, but I'm running LilyDev from a Win10 host.

David

Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

Urs Liska-3
In reply to this post by David Nalesnik


Am 15. November 2019 14:35:26 MEZ schrieb David Nalesnik <[hidden email]>:

>On Fri, Nov 15, 2019 at 12:33 AM Urs Liska <[hidden email]>
>wrote:
>>
>> Hi David,
>>
>> I feel responsible for this because I know where this is coming from
>;-)
>
>Hah! :)  (Seriously, though, this is something that I've wanted and
>Kieren has clamored for...)

Ah yes, you said so back then.

Coincidentally, you can see lots if examples in the project that was released this week.

Urs
>

--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

David Nalesnik
In reply to this post by David Nalesnik
James and all,

On Fri, Nov 15, 2019 at 7:31 AM David Nalesnik <[hidden email]> wrote:
>
> On Fri, Nov 15, 2019 at 4:31 AM James Lowe <[hidden email]> wrote:
> >
> > David et al.

> > >
> > > Am 15.11.19 um 04:10 schrieb David Nalesnik:

> > > > Would someone be willing to shepherd the patch for me?

> >
> > What I would suggest (generally to anyone on this list that ever needs a patch shepherding) is to make sure a tracker exists - @David, as I know you have access to create tickets you can at least do this - and then attach your patch to that and set the tracker to 'started' so that at the very least if (for example) Urs forgets, goes on holiday, has some emergency, that I can at least pick it up/detect it on the countdown and put it up for review myself.
> >
> > I do this all the time for 'drive by' patches.
> >
> > James
> >
>
> Thanks for this explanation.  I discovered that my patch had gone to
> Rietveld, only no ticket was created.  So the error has to do with the
> issue tracker.  Here's hoping that it's possible to do what's left
> manually without too much trouble!
>
> Best,
> David

OK, I _think_ all is well.  I created this issue
https://sourceforge.net/p/testlilyissues/issues/5602/
and provided a link to the Rietveld issue.

Best,
David

Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

Kieren MacMillan-4
In reply to this post by David Nalesnik
Hi David,

> this is something that I've wanted and Kieren has clamored for...

Yes! I’m so excited to see this progress.

Thanks!
Kieren.

Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

James Lowe-3
In reply to this post by David Nalesnik
David,

On 15/11/2019 13:31, David Nalesnik wrote:

> On Fri, Nov 15, 2019 at 4:31 AM James Lowe <[hidden email]> wrote:
>> David et al.
>>
>> On Fri, 15 Nov 2019 07:33:01 +0100, Urs Liska <[hidden email]> wrote:
>>
>>> Hi David,
>>>
>>> I feel responsible for this because I know where this is coming from  ;-)
>>>
>>> You can send me the patch. However, it's a long time since I uploaded
>>> anything, so I'm not sure my set-up still works. But I'll try.
>>>
>>> Best
>>> Urs
>>>
>>> Am 15.11.19 um 04:10 schrieb David Nalesnik:
>>>> Hi all,
>>>>
>>>> I have a patch which implements measure-attached spanners.  I am
>>>> having a devil of a time getting the patch up for review.  I simply
>>>> can't get git-cl to upload it.  (I suspect this has something to do
>>>> with the number of files it touches--my system times out before
>>>> everything can be uploaded.)
>>>>
>>>> Would someone be willing to shepherd the patch for me?
>>>>
>>>> Attached is a PNG which shows the output of one of the regtests.
>>>>
>>>> This would _really_ be appreciated.  Thanks!
>>>>
>>>> David
>> What I would suggest (generally to anyone on this list that ever needs a patch shepherding) is to make sure a tracker exists - @David, as I know you have access to create tickets you can at least do this - and then attach your patch to that and set the tracker to 'started' so that at the very least if (for example) Urs forgets, goes on holiday, has some emergency, that I can at least pick it up/detect it on the countdown and put it up for review myself.
>>
>> I do this all the time for 'drive by' patches.
>>
>> James
>>
> Thanks for this explanation.  I discovered that my patch had gone to
> Rietveld, only no ticket was created.  So the error has to do with the
> issue tracker.  Here's hoping that it's possible to do what's left
> manually without too much trouble!

Status = 'started'

Patch = 'new'

Those two things will get it on the radar.


James


Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

David Nalesnik
Thanks, James!

On Sat, Nov 16, 2019 at 4:07 AM James <[hidden email]> wrote:

>
> David,
>
> On 15/11/2019 13:31, David Nalesnik wrote:
> > On Fri, Nov 15, 2019 at 4:31 AM James Lowe <[hidden email]> wrote:
> >> David et al.
> >>
> >> On Fri, 15 Nov 2019 07:33:01 +0100, Urs Liska <[hidden email]> wrote:
> >>
> >>> Hi David,
> >>>
> >>> I feel responsible for this because I know where this is coming from  ;-)
> >>>
> >>> You can send me the patch. However, it's a long time since I uploaded
> >>> anything, so I'm not sure my set-up still works. But I'll try.
> >>>
> >>> Best
> >>> Urs
> >>>
> >>> Am 15.11.19 um 04:10 schrieb David Nalesnik:
> >>>> Hi all,
> >>>>
> >>>> I have a patch which implements measure-attached spanners.  I am
> >>>> having a devil of a time getting the patch up for review.  I simply
> >>>> can't get git-cl to upload it.  (I suspect this has something to do
> >>>> with the number of files it touches--my system times out before
> >>>> everything can be uploaded.)
> >>>>
> >>>> Would someone be willing to shepherd the patch for me?
> >>>>
> >>>> Attached is a PNG which shows the output of one of the regtests.
> >>>>
> >>>> This would _really_ be appreciated.  Thanks!
> >>>>
> >>>> David
> >> What I would suggest (generally to anyone on this list that ever needs a patch shepherding) is to make sure a tracker exists - @David, as I know you have access to create tickets you can at least do this - and then attach your patch to that and set the tracker to 'started' so that at the very least if (for example) Urs forgets, goes on holiday, has some emergency, that I can at least pick it up/detect it on the countdown and put it up for review myself.
> >>
> >> I do this all the time for 'drive by' patches.
> >>
> >> James
> >>
> > Thanks for this explanation.  I discovered that my patch had gone to
> > Rietveld, only no ticket was created.  So the error has to do with the
> > issue tracker.  Here's hoping that it's possible to do what's left
> > manually without too much trouble!
>
> Status = 'started'
>
> Patch = 'new'
>
> Those two things will get it on the radar.
>
>
> James
>

Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

Trevor Bača-2
In reply to this post by Kieren MacMillan-4
Hi David (and Kieren and Urs),

Awesome. I'll look forward to using measure-attached spanners, too.

Trevor.

On Fri, Nov 15, 2019 at 10:02 AM Kieren MacMillan <
[hidden email]> wrote:

> Hi David,
>
> > this is something that I've wanted and Kieren has clamored for...
>
> Yes! I’m so excited to see this progress.
>
> Thanks!
> Kieren.
>
>

--
Trevor Bača
www.trevorbaca.com
soundcloud.com/trevorbaca
Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

David Nalesnik
Hi Trevor,

On Sun, Dec 1, 2019 at 9:24 PM Trevor Bača <[hidden email]> wrote:
>
> Hi David (and Kieren and Urs),
>
> Awesome. I'll look forward to using measure-attached spanners, too.
>
> Trevor.
>

If you build from current master, you can use them now.  Patch has been pushed!

David

Reply | Threaded
Open this post in threaded view
|

Re: shepherd a patch?

Trevor Bača-2
Hi David,

On Mon, Dec 2, 2019 at 7:57 AM David Nalesnik <[hidden email]>
wrote:

> Hi Trevor,
>
> On Sun, Dec 1, 2019 at 9:24 PM Trevor Bača <[hidden email]> wrote:
> >
> > Hi David (and Kieren and Urs),
> >
> > Awesome. I'll look forward to using measure-attached spanners, too.
> >
> > Trevor.
> >
>
> If you build from current master, you can use them now.  Patch has been
> pushed!
>

Fantastic. Thanks for yet another contribution to my workflow.

Trevor.


--
Trevor Bača
www.trevorbaca.com
soundcloud.com/trevorbaca