regression introduced with issue 5122 "Fix not scaling stem in note-by-number-markup"

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

regression introduced with issue 5122 "Fix not scaling stem in note-by-number-markup"

Thomas Morley-2
As of
https://sourceforge.net/p/testlilyissues/issues/5122/#99dc

commit eee677c480c78d58a5215e246575aa94ba2d1897

introduced a regression.

Not sure when I have the time to look deeper into it.
At first sight I've no good idea for a proper fix.

So I suggest to revert it.
At least it should not go into 2.20 in the current state.

Cheers,
  Harm

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: regression introduced with issue 5122 "Fix not scaling stem in note-by-number-markup"

David Kastrup
Thomas Morley <[hidden email]> writes:

> As of
> https://sourceforge.net/p/testlilyissues/issues/5122/#99dc
>
> commit eee677c480c78d58a5215e246575aa94ba2d1897
>
> introduced a regression.
>
> Not sure when I have the time to look deeper into it.
> At first sight I've no good idea for a proper fix.

Do you have an idea about the underlying problem?

> So I suggest to revert it.
> At least it should not go into 2.20 in the current state.

Noted.

--
David Kastrup

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: regression introduced with issue 5122 "Fix not scaling stem in note-by-number-markup"

Thomas Morley-2
2017-06-13 11:24 GMT+02:00 David Kastrup <[hidden email]>:

> Thomas Morley <[hidden email]> writes:
>
>> As of
>> https://sourceforge.net/p/testlilyissues/issues/5122/#99dc
>>
>> commit eee677c480c78d58a5215e246575aa94ba2d1897
>>
>> introduced a regression.
>>
>> Not sure when I have the time to look deeper into it.
>> At first sight I've no good idea for a proper fix.
>
> Do you have an idea about the underlying problem?

Not yet.
But while investigating:
(1)
There are many properties/procedures with impact on the font size. Among them:
the grob-property 'font-size,
the context-property 'fontSize
the markup-command \fontsize
the procedure layout-set-staff-size
the procedure set-global-staff-size

Even disregarding those for internal use only I'm not sure I listed all of them.

Sometimes they influence eachother...
Looks like a mess.

As a vague guess, I think I should find out which of the above changes
'text-font-size , 'pt, 'staff-height in to which amount.
I'll keep investigating, not much time those days though.

(2)
Probably not related to the issue here, but:
Why does below fail?

\new Score \with { #(layout-set-staff-size 40) }
\new Staff
{ \tempo 8=120 c'2 c' }

-->
error: GUILE signaled an error for the expression beginning here
\new Score \with { #
                    (layout-set-staff-size 40) }
Unbound variable: pt

This works:
\score {
  \new Staff
  { \tempo 8=120 c'2 c' }
  \layout { #(layout-set-staff-size 40) }
}

Cheers,
 Harm

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Loading...