point-and-click broken in 2.9.18 ?

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

point-and-click broken in 2.9.18 ?

Tapio Tuovila
Hello,
it seems that in 2.9.18 generated pdf files all the textedit URIs point
to the 1st row of the .ly code while in 2.9.17 these seemed to be OK.
Also the console error messages show the problematic spots of the code,
but insist that all the problems are located in the first row of the source.

Here two snippets in the middle of a pdf-file, first with 2.9.18 and
second with 2.9.17.

greetings, Tapio

(examples:

/A<</S/URI
/URI(textedit:///home/tapu/Documents/Nuotteja/Rameau/Gavotti/gavotti.ly:1:36:43)>>
/Subtype/Link>>endobj
201 0 obj
<</Type/Annot
/Rect [266.052 363.046 272.628 368.526]
/Border [0 0 0]
/A<</S/URI
/URI(textedit:///home/tapu/Documents/Nuotteja/Rameau/Gavotti/gavotti.ly:1:1:8)>>
/Subtype/Link>>endobj
202 0 obj
<</Type/Annot
/Rect [299.776 359.808 301.768 361.801]
/Border [0 0 0]
/A<</S/URI
/URI(textedit:///home/tapu/Documents/Nuotteja/Rameau/Gavotti/gavotti.ly:1:18:25)>>
/Subtype/Link>>endobj
203 0 obj
<</Type/Annot
/Rect [297.534 350.593 304.06 356.072]
/Border [0 0 0]
/A<</S/URI
/URI(textedit:///home/tapu/Documents/Nuotteja/Rameau/Gavotti/gavotti.ly:1:16:23)>>
/Subtype/Link>>endobj
204 0 obj
<</Type/Annot
/Rect [275.965 350.593 282.54 356.072]
/Border [0 0 0]
/A<</S/URI
/URI(textedit:///home/tapu/Documents/Nuotteja/Rameau/Gavotti/gavotti.ly:1:6:13)>>
/Subtype/Link>>endobj )

the next is generated with 2.9.17

/A<</S/URI
/URI(textedit:///home/tapu/Documents/Nuotteja/Rameau/Gavotti/gavotti.ly:37:35:42)>>
/Subtype/Link>>endobj
201 0 obj
<</Type/Annot
/Rect [373.101 363.046 379.676 368.526]
/Border [0 0 0]
/A<</S/URI
/URI(textedit:///home/tapu/Documents/Nuotteja/Rameau/Gavotti/gavotti.ly:40:5:12)>>
/Subtype/Link>>endobj
202 0 obj
<</Type/Annot
/Rect [357.858 358.065 364.384 363.544]
/Border [0 0 0]
/A<</S/URI
/URI(textedit:///home/tapu/Documents/Nuotteja/Rameau/Gavotti/gavotti.ly:40:1:8)>>
/Subtype/Link>>endobj
203 0 obj
<</Type/Annot
/Rect [140.075 353.084 146.6 358.563]
/Border [0 0 0]
/A<</S/URI
/URI(textedit:///home/tapu/Documents/Nuotteja/Rameau/Gavotti/gavotti.ly:37:49:56)>>
/Subtype/Link>>endobj
204 0 obj
<</Type/Annot
/Rect [142.466 361.054 154.122 366.583]
/Border [0 0 0]
/A<</S/URI
/URI(textedit:///home/tapu/Documents/Nuotteja/Rameau/Gavotti/gavotti.ly:37:52:59)>>
/Subtype/Link>>endobj



_______________________________________________
bug-lilypond mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/bug-lilypond
Reply | Threaded
Open this post in threaded view
|

Re: point-and-click broken in 2.9.18 ?

Han-Wen Nienhuys-2
Tapio Tuovila wrote:

> Hello,
> it seems that in 2.9.18 generated pdf files all the textedit URIs point
> to the 1st row of the .ly code while in 2.9.17 these seemed to be OK.
> Also the console error messages show the problematic spots of the code,
> but insist that all the problems are located in the first row of the source.
>
> Here two snippets in the middle of a pdf-file, first with 2.9.18 and
> second with 2.9.17.
>
> greetings, Tapio
>
> (examples:
>
> /A<</S/URI
> /URI(textedit:///home/tapu/Documents/Nuotteja/Rameau/Gavotti/gavotti.ly:1:36:43)>>
> /Subtype/Link>>endobj
>

Joe,  could this be related to the binsearch chagnes? Source-file.cc
uses it to look up line numbers.

--

Han-Wen Nienhuys - [hidden email] - http://www.xs4all.nl/~hanwen

LilyPond Software Design
  -- Code for Music Notation
http://www.lilypond-design.com



_______________________________________________
bug-lilypond mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/bug-lilypond
Reply | Threaded
Open this post in threaded view
|

Re: point-and-click broken in 2.9.18 ?

Joe Neeman
On Tue, 2006-09-19 at 14:22 +0200, Han-Wen Nienhuys wrote:

> Tapio Tuovila wrote:
> > Hello,
> > it seems that in 2.9.18 generated pdf files all the textedit URIs point
> > to the 1st row of the .ly code while in 2.9.17 these seemed to be OK.
> > Also the console error messages show the problematic spots of the code,
> > but insist that all the problems are located in the first row of the source.
> >
> > Here two snippets in the middle of a pdf-file, first with 2.9.18 and
> > second with 2.9.17.
> >
> > greetings, Tapio
> >
> > (examples:
> >
> > /A<</S/URI
> > /URI(textedit:///home/tapu/Documents/Nuotteja/Rameau/Gavotti/gavotti.ly:1:36:43)>>
> > /Subtype/Link>>endobj
> >
>
> Joe,  could this be related to the binsearch chagnes? Source-file.cc
> uses it to look up line numbers.
My fault indeed. source-file.cc should have lower_bound, not
binary_search.

2006-09-19  Joe Neeman  <[hidden email]>

        * lily/source-file.cc (get_line): lower_bound, not
        binary_search. Fixes problem where point-and-click would
        always point to the first line.

_______________________________________________
bug-lilypond mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/bug-lilypond

tmp.patch (939 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: point-and-click broken in 2.9.18 ?still a bit in .20

Tapio Tuovila

> My fault indeed. source-file.cc should have lower_bound, not
> binary_search.
>
> 2006-09-19  Joe Neeman  <[hidden email]>
>
> * lily/source-file.cc (get_line): lower_bound, not
> binary_search. Fixes problem where point-and-click would
> always point to the first line.
>  
> +
> + * lily/source-file.cc (get_line): lower_bound, not
> + binary_search. Fixes problem where point-and-click would
> + always point to the first line.
>
>  
Well, point-and-click does no longer always point to the first line.
Unfortunately it now points unaccurately somewhere near, one or two rows
down, but not where it should. Last version where this worked accurately
was 2.9.17.

I try to attach a png file to illustrate the problem. Circles show where
I click, where cursor goes and where it should have gone.
Greetings, Tapio

_______________________________________________
bug-lilypond mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/bug-lilypond

point-and-click.png (14K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: point-and-click broken in 2.9.18 ?still a bit in .20

Tapio Tuovila
Tapio Tuovila kirjoitti:

>> My fault indeed. source-file.cc should have lower_bound, not
>> binary_search.
>>
>> 2006-09-19  Joe Neeman  <[hidden email]>
>>
>> * lily/source-file.cc (get_line): lower_bound, not
>> binary_search. Fixes problem where point-and-click would
>> always point to the first line.
>>  
>> +
>> + * lily/source-file.cc (get_line): lower_bound, not
>> + binary_search. Fixes problem where point-and-click would
>> + always point to the first line.
>>
>>  
>>    
> Well, point-and-click does no longer always point to the first line.
> Unfortunately it now points unaccurately somewhere near, one or two rows
> down, but not where it should. Last version where this worked accurately
> was 2.9.17.
>
> I try to attach a png file to illustrate the problem. Circles show where
> I click, where cursor goes and where it should have gone.
> Greetings, Tapio
>  
>
> ------------------------------------------------------------------------
>
> ------------------------------------------------------------------------
>
>  
OOPS, forgot to mention: this was done with CVS ChangeLog/1.5335/Fri Sep
29 09:34:25 2006 on Suse10.1
sorry,
Tapio



_______________________________________________
bug-lilypond mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/bug-lilypond
Reply | Threaded
Open this post in threaded view
|

Re: point-and-click broken in 2.9.18 ?still a bit in .20

Bertalan Fodor (LilyPondTool)
May it have only changed? (I.e. the first line is numbered as 0?)

Bert



_______________________________________________
bug-lilypond mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/bug-lilypond
Reply | Threaded
Open this post in threaded view
|

Re: point-and-click broken in 2.9.18 ?still a bit in .20

Tapio Tuovila
Bertalan Fodor kirjoitti:
> May it have only changed? (I.e. the first line is numbered as 0?)
>
> Bert
>
I think you are right. I tested adding one extra line in the beginning
of the .ly file after compiling, and ta-daa! then point-and-click worked
OK. So, how to fix this?

Tapio



_______________________________________________
bug-lilypond mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/bug-lilypond
Reply | Threaded
Open this post in threaded view
|

Re: point-and-click broken in 2.9.18 ?still a bit in .20

Bertalan Fodor (LilyPondTool)
Well, it should be decided by LilyPond developers if this is the
intended behaviour or it is a bug. The point-and-click handling is
compiled into the source of LilyPondTool, so it can not be easily
parametrized.

Bert

Tapio Tuovila írta:

> Bertalan Fodor kirjoitti:
>  
>> May it have only changed? (I.e. the first line is numbered as 0?)
>>
>> Bert
>>
>>    
> I think you are right. I tested adding one extra line in the beginning
> of the .ly file after compiling, and ta-daa! then point-and-click worked
> OK. So, how to fix this?
>
> Tapio
>
>  




_______________________________________________
bug-lilypond mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/bug-lilypond
Reply | Threaded
Open this post in threaded view
|

Re: point-and-click broken in 2.9.18 ?still a bit in .20

Han-Wen Nienhuys-2

this is still a bug. Joe?

Bertalan Fodor schreef:
> Well, it should be decided by LilyPond developers if this is the
> intended behaviour or it is a bug. The point-and-click handling is
> compiled into the source of LilyPondTool, so it can not be easily
> parametrized.

--

Han-Wen Nienhuys - [hidden email] - http://www.xs4all.nl/~hanwen

LilyPond Software Design
  -- Code for Music Notation
http://www.lilypond-design.com



_______________________________________________
bug-lilypond mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/bug-lilypond
Reply | Threaded
Open this post in threaded view
|

Re: point-and-click broken in 2.9.18 ?still a bit in .20

Joe Neeman
On Fri, 2006-09-29 at 14:21 +0200, Han-Wen Nienhuys wrote:
> this is still a bug. Joe?
Yes, it seems I misread the lower_bound specification. I've fixed this
one but I need to review the use of lower_bound in page-turn-engraver
also.

>
> Bertalan Fodor schreef:
> > Well, it should be decided by LilyPond developers if this is the
> > intended behaviour or it is a bug. The point-and-click handling is
> > compiled into the source of LilyPondTool, so it can not be easily
> > parametrized.
>


_______________________________________________
bug-lilypond mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/bug-lilypond