patch to constrained-breaking

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

patch to constrained-breaking

Joe Neeman
This contains a bug-fix, an optimisation (been doing some profiling :)) and a
new feature (adding page-turn-penalties). The bug-fix and the feature won't
affect 2.8 because 2.7 doesn't use the full capabilities of the
constrained-breaker, but I think the bug fix at least should go in.

_______________________________________________
lilypond-devel mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/lilypond-devel

breaking_20060308.patch (6K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: patch to constrained-breaking

Han-Wen Nienhuys-2
Joe Neeman wrote:
> This contains a bug-fix, an optimisation (been doing some profiling :)) and a

> + (combine_demerits): use pointers to reduce copying data

Are you sure about this? AFAIK references are internally handled in the
same way as pointers.

--

Han-Wen Nienhuys - [hidden email] - http://www.xs4all.nl/~hanwen

LilyPond Software Design
  -- Code for Music Notation
http://www.lilypond-design.com



_______________________________________________
lilypond-devel mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: patch to constrained-breaking

Joe Neeman
On Sat, 11 Mar 2006 06:13 am, Han-Wen Nienhuys wrote:
> Joe Neeman wrote:
> > This contains a bug-fix, an optimisation (been doing some profiling :))
> > and a
> >
> > + (combine_demerits): use pointers to reduce copying data
>
> Are you sure about this? AFAIK references are internally handled in the
> same way as pointers.
The actual optimisations were in calc_subproblem. But I needed to be able to
pass an empty value to combine_demerits. Using a null pointer instead of a
reference allowed me to use pointers instead of values in calc_subproblem.

Column_x_positions::operator= used to be disturbingly high in the call graph
part of the profile, but now it's pretty much gone.


_______________________________________________
lilypond-devel mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/lilypond-devel