add articulation support to multi measure rests (issue 562710043 by lilypond@maltemeyn.de)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

add articulation support to multi measure rests (issue 562710043 by lilypond@maltemeyn.de)

lemzwerg
Without testing: LGTM, thanks!


https://codereview.appspot.com/562710043/diff/582610043/input/regression/multi-measure-rest-text.ly
File input/regression/multi-measure-rest-text.ly (right):

https://codereview.appspot.com/562710043/diff/582610043/input/regression/multi-measure-rest-text.ly#newcode20
input/regression/multi-measure-rest-text.ly:20: R2.^\shortfermata
Shouldn't this be rather `\shortFermata'?

https://codereview.appspot.com/562710043/diff/582610043/scm/define-music-types.scm
File scm/define-music-types.scm (right):

https://codereview.appspot.com/562710043/diff/582610043/scm/define-music-types.scm#newcode317
scm/define-music-types.scm:317: . ((description . "Articulations on
multi measure rests.")
multi measure → multi-measure

https://codereview.appspot.com/562710043/
_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: add articulation support to multi measure rests (issue 562710043 by lilypond@maltemeyn.de)

Malte Meyn-3
Reviewers: lemzwerg,


https://codereview.appspot.com/562710043/diff/582610043/input/regression/multi-measure-rest-text.ly
File input/regression/multi-measure-rest-text.ly (right):

https://codereview.appspot.com/562710043/diff/582610043/input/regression/multi-measure-rest-text.ly#newcode20
input/regression/multi-measure-rest-text.ly:20: R2.^\shortfermata
On 2019/04/19 15:34:25, lemzwerg wrote:
> Shouldn't this be rather `\shortFermata'?

No, \shortfermata is the current command name. Changing it is not in the
scope of this issue (5511), but related issues are 5487 and maybe 5486:
I haven’t added script commands for very short and Henze fermatas yet.

https://codereview.appspot.com/562710043/diff/582610043/scm/define-music-types.scm
File scm/define-music-types.scm (right):

https://codereview.appspot.com/562710043/diff/582610043/scm/define-music-types.scm#newcode317
scm/define-music-types.scm:317: . ((description . "Articulations on
multi measure rests.")
On 2019/04/19 15:34:25, lemzwerg wrote:
> multi measure → multi-measure

Yep. Same at line 338 and 329, that’ll be part of the next patch set.

Description:
add articulation support to multi measure rests

This adds an event type MultiMeasureArticulationEvent and a grob type
MultiMeasureRestScript and allows to add articulations/scripts to multi
measure rests. This means that you can use \fermata now instead of
\fermataMarkup.

\fermataMarkup is deprecated, the regression tests are updated
(convert-ly + manual changes in stencil-scale.ly and
multi-measure-rest-text.ly).

Please review this at https://codereview.appspot.com/562710043/

Affected files (+134, -43 lines):
   M input/regression/fermata-rest-position.ly
   M input/regression/full-measure-rest-fermata.ly
   M input/regression/morgenlied.ly
   M input/regression/multi-measure-rest-text.ly
   M input/regression/stencil-scale.ly
   M lily/multi-measure-rest-engraver.cc
   M ly/engraver-init.ly
   M ly/property-init.ly
   M python/convertrules.py
   M scm/define-event-classes.scm
   M scm/define-grobs.scm
   M scm/define-music-display-methods.scm
   M scm/define-music-types.scm
   M scm/ly-syntax-constructors.scm


_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel