Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

paulwmorris
Reviewers: ,

Message:
Please review.  I realized after changing the file names that it might
not have been the best approach.  I'm not sure how it will affect
translations of the site.  Not hard to change them back in a revised
patch, but in the long run I think these newer names are clearer.

Two screenshots attached to the issue tracker:
https://sourceforge.net/p/testlilyissues/issues/5078/

-Paul



Description:
Web: Move older news to the attic page

Please review this at https://codereview.appspot.com/318630043/

Affected files (+24, -6549 lines):
   M Documentation/common-macros.itexi
   M Documentation/contributor/release-work.itexi
   M Documentation/web/community.itexi
   D Documentation/web/news.itexi
   D Documentation/web/news-front.itexi
   A + Documentation/web/news-new.itexi
   A + Documentation/web/news-old.itexi



_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

Urs Liska


Am 27.02.2017 um 05:27 schrieb [hidden email]:

> Reviewers: ,
>
> Message:
> Please review.  I realized after changing the file names that it might
> not have been the best approach.  I'm not sure how it will affect
> translations of the site.  Not hard to change them back in a revised
> patch, but in the long run I think these newer names are clearer.
>
> Two screenshots attached to the issue tracker:
> https://sourceforge.net/p/testlilyissues/issues/5078/

Judging from the screenshots only.

The new news.html LGTM.
I suggest to move the GSoC 2016 "news" to the old news as well, once
your patches have gone through (maybe rather not include this in the
current patch).

With the "old news" page the screenshot doesn't really tell me what you did.
Would you mind explaining "in plain words", which items are moved from
where to where?

From the Patch Set overview I have the impression you didn't *move* the
news items but rather deleted them (-6393 lines that don't show up
anywhere else). Is there maybe some file missing in the patch?

Sorry, somewhat confused with the patch.
Urs

> -Paul
>
>
>
> Description:
> Web: Move older news to the attic page
>
> Please review this at https://codereview.appspot.com/318630043/
>
> Affected files (+24, -6549 lines):
>   M Documentation/common-macros.itexi
>   M Documentation/contributor/release-work.itexi
>   M Documentation/web/community.itexi
>   D Documentation/web/news.itexi
>   D Documentation/web/news-front.itexi
>   A + Documentation/web/news-new.itexi
>   A + Documentation/web/news-old.itexi
>
>
>
> _______________________________________________
> lilypond-devel mailing list
> [hidden email]
> https://lists.gnu.org/mailman/listinfo/lilypond-devel

--
[hidden email]
https://openlilylib.org
http://lilypondblog.org


_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

Federico Bruni-2
Il giorno lun 27 feb 2017 alle 11:49, Urs Liska <[hidden email]> ha
scritto:
> With the "old news" page the screenshot doesn't really tell me what
> you did. Would you mind explaining "in plain words", which items are
> moved from where to where?

He moved the old news to the bottom of this page:
http://lilypond.org/attic.html


> From the Patch Set overview I have the impression you didn't *move*
> the news items but rather deleted them (-6393 lines that don't show
> up anywhere else). Is there maybe some file missing in the patch?
> Sorry, somewhat confused with the patch.

The old news are now in the file news-old.itexi, which is included
within the attic section of the website. Probably you did not unfold
the page on rietveld:
https://codereview.appspot.com/318630043/diff/1/Documentation/web/news-old.itexi




_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

Federico Bruni
In reply to this post by paulwmorris
On 2017/02/27 04:27:45, pwm wrote:
> Please review.  I realized after changing the file names that it might
not have
> been the best approach.  I'm not sure how it will affect translations
of the
> site.  Not hard to change them back in a revised patch, but in the
long run I
> think these newer names are clearer.


LGTM

No problem about file renaming. The git diff will tell translators what
to do.
As a translator, I'm very happy with this patch because finally I can
translate a small news page with the latest news entries and leave the
old news untranslated.



https://codereview.appspot.com/318630043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

Urs Liska
In reply to this post by Federico Bruni-2


Am 27.02.2017 um 12:46 schrieb Federico Bruni:
> Il giorno lun 27 feb 2017 alle 11:49, Urs Liska <[hidden email]>
> ha scritto:
>> With the "old news" page the screenshot doesn't really tell me what
>> you did. Would you mind explaining "in plain words", which items are
>> moved from where to where?
>
> He moved the old news to the bottom of this page:
> http://lilypond.org/attic.html

OK, so then the screenshot was wrongly named old-news.png?

But if we do this we should do something about the organization of
different parts of the page.
Probably applying the same method as in
https://sourceforge.net/p/testlilyissues/issues/5075/, whatever the
eventual outcome of this will be.

>
>
>> From the Patch Set overview I have the impression you didn't *move*
>> the news items but rather deleted them (-6393 lines that don't show
>> up anywhere else). Is there maybe some file missing in the patch?
>> Sorry, somewhat confused with the patch.
>
> The old news are now in the file news-old.itexi, which is included
> within the attic section of the website. Probably you did not unfold
> the page on rietveld:
> https://codereview.appspot.com/318630043/diff/1/Documentation/web/news-old.itexi
>
>

But news-old.itexi only shows one changed line in the overview. I didn't
realize that it's a new/renamed file with one *additional* change.

So I think it LGTM, with the exception of the above comment about the
nesting, which may be changed in this patch or applied later when 5075
has been decided upon.

Urs


--

[hidden email]
https://openlilylib.org
http://lilypondblog.org


_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

Paul Morris
On 02/27/2017 06:59 AM, Urs Liska wrote:

> Am 27.02.2017 um 12:46 schrieb Federico Bruni:
>> Il giorno lun 27 feb 2017 alle 11:49, Urs Liska <[hidden email]>
>> ha scritto:
>>> With the "old news" page the screenshot doesn't really tell me what
>>> you did. Would you mind explaining "in plain words", which items are
>>> moved from where to where?
>> He moved the old news to the bottom of this page:
>> http://lilypond.org/attic.html
> OK, so then the screenshot was wrongly named old-news.png?

"start-of-old-news-section-on-attic-page.png" would have been clearer.  
I tried to do a screenshot of the whole page but it's so long my
screenshot add-on choked on it.  (See also the issue title.)

> But if we do this we should do something about the organization of
> different parts of the page.
> Probably applying the same method as in
> https://sourceforge.net/p/testlilyissues/issues/5075/, whatever the
> eventual outcome of this will be.

Yep, that's that other issue.  I didn't see a reason not to go ahead and
move the old news to the attic page, especially since it's so
low-traffic, .  Then we can figure out what, if anything, we want to do
further.

Glad to know the new file names will not negatively impact the
translations of the site.

-Paul


_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

pkx166h
In reply to this post by paulwmorris
Fails make doc.

Seems to be a problem in the Catalan translations.

Processing web site: [ca]
*** Can't find web/news.itexi, skipping (in
/home/james/lilypond-git/Documentati
on/ca/web/community.itexi l. 1208)
Max error number exceeded



https://codereview.appspot.com/318630043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

Jean-Charles Malahieude-2
In reply to this post by paulwmorris
https://codereview.appspot.com/318630043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

Jean-Charles Malahieude-2
In reply to this post by paulwmorris
On 2017/03/04 18:02:28, pkx166h wrote:
> Fails make doc.

> Seems to be a problem in the Catalan translations.

> Processing web site: [ca]
> *** Can't find web/news.itexi, skipping (in
/home/james/lilypond-git/Documentati
> on/ca/web/community.itexi l. 1208)
> Max error number exceeded

This line contains @include web/news.itexi that no longer exists.
It barfs because ca/ is the first alphabetically translations' subdir.

All LL/web/community.itexi should then be adapted.

No time to test this evening, must leave now.

https://codereview.appspot.com/318630043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

pkx166h
In reply to this post by paulwmorris
On 2017/03/04 18:44:28, Jean-Charles wrote:

> On 2017/03/04 18:02:28, pkx166h wrote:
> > Fails make doc.
> >
> > Seems to be a problem in the Catalan translations.
> >
> > Processing web site: [ca]
> > *** Can't find web/news.itexi, skipping (in
> /home/james/lilypond-git/Documentati
> > on/ca/web/community.itexi l. 1208)
> > Max error number exceeded

> This line contains @include web/news.itexi that no longer exists.
> It barfs because ca/ is the first alphabetically translations' subdir.

> All LL/web/community.itexi should then be adapted.

> No time to test this evening, must leave now.

I'll have a go at fixing this now.

James

https://codereview.appspot.com/318630043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

paulwmorris
In reply to this post by paulwmorris
On 2017/03/04 20:52:49, pkx166h wrote:

> I'll have a go at fixing this now.

Thanks, I haven't had a chance to work on this yet.  Sorry I didn't try
a 'make doc' before uploading for review.  Since 'make website'
succeeded I thought it was good to go... but that's not the case.

One simple solution would be: Instead of renaming those two files (which
breaks the translations), effectively create copies of them and rename
the copies.  Then later after the translations have been updated to use
the new files, delete the old copies with the old names.  (Of course
building on patch set 1, one would copy the new versions and give them
the old names...)

-Paul

https://codereview.appspot.com/318630043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

Federico Bruni-2


Il giorno dom 5 mar 2017 alle 1:25, [hidden email] ha scritto:
> On 2017/03/04 20:52:49, pkx166h wrote:
>
>> I'll have a go at fixing this now.
>
> Thanks, I haven't had a chance to work on this yet.  Sorry I didn't
> try
> a 'make doc' before uploading for review.  Since 'make website'
> succeeded I thought it was good to go... but that's not the case.
>

This is strange, since the problem is in the website manual. Perhaps
you built only the english website?

> One simple solution would be: Instead of renaming those two files
> (which
> breaks the translations), effectively create copies of them and rename
> the copies.  Then later after the translations have been updated to
> use
> the new files, delete the old copies with the old names.  (Of course
> building on patch set 1, one would copy the new versions and give them
> the old names...)
>
>

This is the easier solution, but what about the translations that are
not maintained? These won't be updated by anybody.. and you can't keep
(and update?) two copies of the same files just because of these
abandoned translations.

I think that the best solution is updating the included link in all the
translations which did not translate news.itexi or new-front.itexi:

$ find Documentation/ -name news.itexi
Documentation/es/web/news.itexi
Documentation/web/news.itexi

$ find Documentation/ -name news-front.itexi
Documentation/ca/web/news-front.itexi
Documentation/es/web/news-front.itexi
Documentation/web/news-front.itexi
Documentation/zh/web/news-front.itexi


So the commands to change the links could be:

$ git grep -l "@include web/news.itexi" | xargs sed -i "s|@include
web/news.itexi|@include web/news-old.itexi|g"
$ git checkout Documentation/es/web/community.itexi

$ git grep -l "@include web/news-front.itexi" | xargs sed -i
"s|@include web/news-front.itexi|@include web/news-new.itexi|g"
$ git checkout Documentation/ca/web/community.itexi
Documentation/es/web/community.itexi
Documentation/zh/web/community.itexi









_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

Federico Bruni-2


Il giorno dom 5 mar 2017 alle 8:53, Federico Bruni <[hidden email]>
ha scritto:

>
>
> I think that the best solution is updating the included link in all
> the translations which did not translate news.itexi or
> new-front.itexi:
>
> $ find Documentation/ -name news.itexi
> Documentation/es/web/news.itexi
> Documentation/web/news.itexi
>
> $ find Documentation/ -name news-front.itexi
> Documentation/ca/web/news-front.itexi
> Documentation/es/web/news-front.itexi
> Documentation/web/news-front.itexi
> Documentation/zh/web/news-front.itexi
>
>
> So the commands to change the links could be:
>
> $ git grep -l "@include web/news.itexi" | xargs sed -i "s|@include
> web/news.itexi|@include web/news-old.itexi|g"
> $ git checkout Documentation/es/web/community.itexi
>

Of course do the commit before going on.


> $ git grep -l "@include web/news-front.itexi" | xargs sed -i
> "s|@include web/news-front.itexi|@include web/news-new.itexi|g"
> $ git checkout Documentation/ca/web/community.itexi
> Documentation/es/web/community.itexi
> Documentation/zh/web/community.itexi
>
>

Then git commit --amend





_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

pkx166h
In reply to this post by paulwmorris
On 2017/03/05 00:25:33, pwm wrote:
> On 2017/03/04 20:52:49, pkx166h wrote:
> >
> > I'll have a go at fixing this now.

> Thanks, I haven't had a chance to work on this yet.  Sorry I didn't
try a 'make
> doc' before uploading for review.  Since 'make website' succeeded I
thought it
> was good to go... but that's not the case.

Don't worry, it wouldn't be the first time this kind of thing has
happened :)


> One simple solution would be: Instead of renaming those two files
(which breaks
> the translations), effectively create copies of them and rename the
copies.
> Then later after the translations have been updated to use the new
files, delete
> the old copies with the old names.  (Of course building on patch set
1, one
> would copy the new versions and give them the old names...)


No I think probably the simplest thing is to just add/change the
@include references as Jean-Charles and Federico pointed out. I did a
quick and dirty test last night when I saw Jean-Charle's comment [1] and
I replaced the links in the community.texi files from the other
languages - well, all but one - that I had missed in my haste - and it
of course failed on that one, which just confirmed Jean-Charle's
diagnoses.

What I will do is take your checkin, add my bits and pieces and
re-submit the tracker and Rietveld to save you the bother - obviously
when the patch is pushed I'll make sure you get the credit in the
authorship. Then the translator-people can make sure it is OK as well.

Because of the nature of how different translations get further and
further away at different rates compared to the English version the
addition of the 'old news' link - which I think is important, is just a
simple @include at the end of the community.itexi file.

As I cannot speak all the languages that are being translated, there
will be no 'if you want to see the new news go to @ref{xxxx}' but just
the @include statement which is better than nothing. Although the
translators may disagree.

I'll ge to work on that now.

James


[1] Thanks Jean-Charles, I should have thought of that, at least now I
know why when I make some test patches on my side it's always the
Catalan translation that seems to cause problems (i.e. it isn't, it's
just that that is the first one in the list of translated languages), so
now I know this it will help me in the future to diagnose problems more
quickly.



https://codereview.appspot.com/318630043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Web: Move older news to the attic page (issue 318630043 by paulwmorris@gmail.com)

pkx166h
In reply to this post by paulwmorris
I've updated the tracker to use this Rietveld

https://codereview.appspot.com/320290043/

I'll make sure Paul gets the credit when the patch is eventually pushed.

https://codereview.appspot.com/318630043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel