Various chain-assoc-get -> #:properties (issue 323940043 by dak@gnu.org)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Various chain-assoc-get -> #:properties (issue 323940043 by dak@gnu.org)

Thomas Morley-2
LGTM

one nit:


https://codereview.appspot.com/323940043/diff/1/Documentation/snippets/three-sided-box.ly
File Documentation/snippets/three-sided-box.ly (right):

https://codereview.appspot.com/323940043/diff/1/Documentation/snippets/three-sided-box.ly#newcode45
Documentation/snippets/three-sided-box.ly:45: (m (interpret-markup
layout props arg)))
tab->spaces

https://codereview.appspot.com/323940043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Various chain-assoc-get -> #:properties (issue 323940043 by dak@gnu.org)

Carl Sorensen
LGTM.

One small possible change.


https://codereview.appspot.com/323940043/diff/20001/Documentation/snippets/new/three-sided-box.ly
File Documentation/snippets/new/three-sided-box.ly (right):

https://codereview.appspot.com/323940043/diff/20001/Documentation/snippets/new/three-sided-box.ly#newcode36
Documentation/snippets/new/three-sided-box.ly:36: (let* ((pad (*
(magstep font-size) box-padding))
Looks like this could now be a let instead of let*

https://codereview.appspot.com/323940043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Various chain-assoc-get -> #:properties (issue 323940043 by dak@gnu.org)

David Kastrup
In reply to this post by Thomas Morley-2

https://codereview.appspot.com/323940043/diff/20001/Documentation/snippets/new/three-sided-box.ly
File Documentation/snippets/new/three-sided-box.ly (right):

https://codereview.appspot.com/323940043/diff/20001/Documentation/snippets/new/three-sided-box.ly#newcode36
Documentation/snippets/new/three-sided-box.ly:36: (let* ((pad (*
(magstep font-size) box-padding))
On 2017/06/16 21:59:49, Carl wrote:
> Looks like this could now be a let instead of let*

Done.  Not going to create a new review for it though.

https://codereview.appspot.com/323940043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel