Remove @ substitutions from python/*.py (issue 549740043 by hanwenn@gmail.com)

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Remove @ substitutions from python/*.py (issue 549740043 by hanwenn@gmail.com)

jonas.hahnfeld
Could you please copy the comment to all places where you paste the
code?

https://codereview.appspot.com/549740043/

Reply | Threaded
Open this post in threaded view
|

Re: Remove @ substitutions from python/*.py (issue 549740043 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
Reviewers: hahnjo,

Message:
On 2020/03/21 08:56:20, hahnjo wrote:
> Could you please copy the comment to all places where you paste the
code?

sure.

Note that the comment is just paraphrasing the documentation for
gettext.install https://docs.python.org/3/library/gettext.html

Description:
Remove @ substitutions from python/*.py

Makes the files from python/ directly importable from source.

Please review this at https://codereview.appspot.com/549740043/

Affected files (+130, -141 lines):
  M python/lilylib.py
  M scripts/abc2ly.py
  M scripts/convert-ly.py
  M scripts/etf2ly.py
  M scripts/lilypond-book.py
  M scripts/midi2ly.py
  M scripts/musicxml2ly.py



Reply | Threaded
Open this post in threaded view
|

Re: Remove @ substitutions from python/*.py (issue 549740043 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
In reply to this post by jonas.hahnfeld
Reply | Threaded
Open this post in threaded view
|

Re: Remove @ substitutions from python/*.py (issue 549740043 by hanwenn@gmail.com)

jonas.hahnfeld
In reply to this post by jonas.hahnfeld
On 2020/03/21 11:16:12, hanwenn wrote:
> PTAL

Very please don't clutter diffs with unrelated whitespace changes. If
you think we should apply this, please do so independently. After a
message to lilypond-devel they can probably go into staging -> master
directly without much review.

Also please update the title (here and SF issue) to accommodate to the
"larger cleanup".

https://codereview.appspot.com/549740043/

Reply | Threaded
Open this post in threaded view
|

Re: Remove @ substitutions from python/*.py (issue 549740043 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
In reply to this post by jonas.hahnfeld
On 2020/03/21 11:22:15, hahnjo wrote:
> On 2020/03/21 11:16:12, hanwenn wrote:
> > PTAL
>
> Very please don't clutter diffs with unrelated whitespace changes. If
you think
> we should apply this, please do so independently. After a message to
> lilypond-devel they can probably go into staging -> master directly
without much
> review.

For context: many projects that I contribute to keep harping about
trailing whitespace,
hence I added

  (add-hook 'before-save-hook 'delete-trailing-whitespace)

to my .emacs. I uploaded

  https://codereview.appspot.com/547810043

(I tried doing the whole codebase, but Rietveld times out. Is there any
movement on
the plan to switch infrastructure?)

> Also please update the title (here and SF issue) to accommodate to the
"larger
> cleanup".


Done.


https://codereview.appspot.com/549740043/

Reply | Threaded
Open this post in threaded view
|

Re: Remove @ substitutions from python/*.py (issue 549740043 by hanwenn@gmail.com)

Dan Eble
On Mar 21, 2020, at 08:25, [hidden email] wrote:
>
> For context: many projects that I contribute to keep harping about
> trailing whitespace

I recently started using the ws-butler package to limit whitespace changes to lines that also have substantive changes.  It has helped me.

https://github.com/lewang/ws-butler

Dan