Remove spurious '% begin verbatim' in Documentation/snippets/new (issue 583000043 by dak@gnu.org)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Remove spurious '% begin verbatim' in Documentation/snippets/new (issue 583000043 by dak@gnu.org)

benko.pal
LGTM


https://codereview.appspot.com/583000043/diff/568950043/Documentation/snippets/figured-bass-headword.ly
File Documentation/snippets/figured-bass-headword.ly (right):

https://codereview.appspot.com/583000043/diff/568950043/Documentation/snippets/figured-bass-headword.ly#newcode35
Documentation/snippets/figured-bass-headword.ly:35:
I guess there should be no empty line at all here

https://codereview.appspot.com/583000043/diff/568950043/Documentation/snippets/heavily-customized-polymetric-time-signatures.ly
File
Documentation/snippets/heavily-customized-polymetric-time-signatures.ly
(right):

https://codereview.appspot.com/583000043/diff/568950043/Documentation/snippets/heavily-customized-polymetric-time-signatures.ly#newcode39
Documentation/snippets/heavily-customized-polymetric-time-signatures.ly:39:
\new Staff \with {
indentation unneeded in this block

https://codereview.appspot.com/583000043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Remove spurious '% begin verbatim' in Documentation/snippets/new (issue 583000043 by dak@gnu.org)

Dev mailing list
LGTM, too.  No need to add any further formatting right now.  After
finishing my indexing stuff I will do a second sweep to format all
snippets (used in the manual).

[And it can be directly added to staging IMHO.]

https://codereview.appspot.com/583000043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Remove spurious '% begin verbatim' in Documentation/snippets/new (issue 583000043 by dak@gnu.org)

David Kastrup
In reply to this post by benko.pal
Reviewers: benko.pal, lemzwerg,


https://codereview.appspot.com/583000043/diff/568950043/Documentation/snippets/figured-bass-headword.ly
File Documentation/snippets/figured-bass-headword.ly (right):

https://codereview.appspot.com/583000043/diff/568950043/Documentation/snippets/figured-bass-headword.ly#newcode35
Documentation/snippets/figured-bass-headword.ly:35:
On 2019/09/24 07:42:27, benko.pal wrote:
> I guess there should be no empty line at all here

All other \with blocks have the same silly empty line, so there is no
point in changing this particular occurence in connection with % begin
verbatim while leaving all the others.

Feel free to reformat in a different issue.  Needs doing so in
Documentation/snippets/new if you want to do it.

https://codereview.appspot.com/583000043/diff/568950043/Documentation/snippets/heavily-customized-polymetric-time-signatures.ly
File
Documentation/snippets/heavily-customized-polymetric-time-signatures.ly
(right):

https://codereview.appspot.com/583000043/diff/568950043/Documentation/snippets/heavily-customized-polymetric-time-signatures.ly#newcode39
Documentation/snippets/heavily-customized-polymetric-time-signatures.ly:39:
\new Staff \with {
On 2019/09/24 07:42:28, benko.pal wrote:
> indentation unneeded in this block

Separate independent format issue.  Worth fixing, but not really
connected to this issue.

Description:
Remove spurious '% begin verbatim' in Documentation/snippets/new

Also:

Run scripts/auxiliar/makelsr.py

Please review this at https://codereview.appspot.com/583000043/

Affected files (+53, -52 lines):
   M Documentation/snippets/adding-drum-parts.ly
   M Documentation/snippets/aiken-head-thin-variant-noteheads.ly
   M Documentation/snippets/aligning-and-centering-instrument-names.ly
   M Documentation/snippets/automatic-fretboards-barre.ly
   M Documentation/snippets/clip-systems.ly
   M Documentation/snippets/combining-two-parts-on-the-same-staff.ly
   M Documentation/snippets/figured-bass-headword.ly
   M Documentation/snippets/heavily-customized-polymetric-time-signatures.ly
   M  
Documentation/snippets/horizontally-aligning-custom-dynamics-e.g.-sempre-pp,-piu-f,-subito-p.ly
   M Documentation/snippets/jazz-combo-template.ly
   M Documentation/snippets/new/adding-drum-parts.ly
   M Documentation/snippets/new/aiken-head-thin-variant-noteheads.ly
   M Documentation/snippets/new/aligning-and-centering-instrument-names.ly
   M Documentation/snippets/new/automatic-fretboards-barre.ly
   M Documentation/snippets/new/clip-systems.ly
   M Documentation/snippets/new/combining-two-parts-on-the-same-staff.ly
   M Documentation/snippets/new/figured-bass-headword.ly
   M  
Documentation/snippets/new/heavily-customized-polymetric-time-signatures.ly
   M  
Documentation/snippets/new/horizontally-aligning-custom-dynamics-e.g.-sempre-pp,-piu-f,-subito-p.ly
   M Documentation/snippets/new/jazz-combo-template.ly
   M Documentation/snippets/new/orchestra,-choir-and-piano-template.ly
   M Documentation/snippets/new/piano-template-simple.ly
   M Documentation/snippets/new/quoting-another-voice.ly
   M Documentation/snippets/new/quoting-another-voice-with-transposition.ly
   M Documentation/snippets/new/string-quartet-template-simple.ly
   M  
Documentation/snippets/new/string-quartet-template-with-separate-parts.ly
   M Documentation/snippets/new/turkish-makam-example.ly
   M Documentation/snippets/new/utf-8.ly
   M Documentation/snippets/orchestra,-choir-and-piano-template.ly
   M Documentation/snippets/piano-template-simple.ly
   M Documentation/snippets/quoting-another-voice.ly
   M Documentation/snippets/quoting-another-voice-with-transposition.ly
   M Documentation/snippets/string-quartet-template-simple.ly
   M Documentation/snippets/string-quartet-template-with-separate-parts.ly
   M Documentation/snippets/turkish-makam-example.ly
   M Documentation/snippets/utf-8.ly



_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel