Remove log-clean target (issue 561450044 by hanwenn@gmail.com)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Remove log-clean target (issue 561450044 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
Reviewers: ,

Message:
commit 47f3fe73176d876bd87fa787b76e5d97f315c613
Author: Han-Wen Nienhuys <[hidden email]>
Date:   Fri Feb 14 23:52:44 2020 +0100

    Remove log-clean target
   


Description:
Remove log-clean target

In particular, remove it as a subtarget of "make distclean".  This
helps the Docker CI scripts at https://github.com/hanwen/lilypond-ci

Please review this at https://codereview.appspot.com/561450044/

Affected files (+4, -9 lines):
  M Documentation/included/compile.itexi
  M stepmake/stepmake/generic-targets.make
  M stepmake/stepmake/toplevel-targets.make


Index: Documentation/included/compile.itexi
diff --git a/Documentation/included/compile.itexi b/Documentation/included/compile.itexi
index 749c92d4429f30b139b932539d9c68933559bc70..7fb9502b71e4ea97917c2e17f6f7c4f03dca584a 100644
--- a/Documentation/included/compile.itexi
+++ b/Documentation/included/compile.itexi
@@ -1088,7 +1088,7 @@ logfiles are not deleted with @command{make@tie{}doc-clean}.  To
 remove all the logfiles generated by the compilation process, use:
 
 @example
-make log-clean
+find -name '*.log' -delete
 @end example
 
 @code{make@tie{}doc} compiles the documents for all languages.  To
Index: stepmake/stepmake/generic-targets.make
diff --git a/stepmake/stepmake/generic-targets.make b/stepmake/stepmake/generic-targets.make
index 251bd2d8ceca8dc6dd34943ed791fba0322929eb..e1dd89a0ad44bae0ae177571539c5ad72cceb8ae 100644
--- a/stepmake/stepmake/generic-targets.make
+++ b/stepmake/stepmake/generic-targets.make
@@ -1,6 +1,6 @@
 .PHONY : all clean bin-clean default dist exe help html lib man TAGS\
  po doc doc-stage-1 WWW-1 WWW-2 WWW-post local-WWW-1 local-WWW-2\
- local-all local-clean local-bin-clean local-doc log-clean
+ local-all local-clean local-bin-clean local-doc
 
 all: default
  $(LOOP)
@@ -14,9 +14,6 @@ clean: local-clean
  -rm -rf $(outdir)
  $(LOOP)
 
-log-clean:
- find . -name "*.log" -delete
-
 ifeq (,$(findstring metafont,$(STEPMAKE_TEMPLATES)))
 bin-clean: local-bin-clean
  -rm -rf $(outdir)
@@ -59,7 +56,6 @@ help: generic-help local-help
  @echo "  exe          update all executables"
  @echo "  help         this help"
  @echo "  lib          update all libraries"
- @echo "  log-clean    remove .log files"
  @echo "  TAGS         generate tagfiles"
  @echo
  @echo "\`make' may be invoked from any subdirectory that contains a GNUmakefile."
Index: stepmake/stepmake/toplevel-targets.make
diff --git a/stepmake/stepmake/toplevel-targets.make b/stepmake/stepmake/toplevel-targets.make
index e8f0a122eb5122b9c8d12be5f050c02f3e50944d..4de63d27c9aa24be92c73d85f0ebce511fe529f7 100644
--- a/stepmake/stepmake/toplevel-targets.make
+++ b/stepmake/stepmake/toplevel-targets.make
@@ -2,7 +2,7 @@
 install-doc:
 uninstall-doc:
 
-distclean: clean doc-clean test-clean log-clean
+distclean: clean doc-clean test-clean
  $(MAKE) local-distclean
 
 local-distclean:
@@ -32,7 +32,7 @@ endif
 local-help:
  @echo "  config          rerun configure"
  @echo "  dist            roll tarball: $(depth)/$(outdir)/$(distname).tar.gz"
- @echo "  distclean       make clean, doc-clean, test-clean, log-clean and"
+ @echo "  distclean       make clean, doc-clean, test-clean and"
  @echo "                   also remove configure output"
  @echo "  po              make new translation Portable Object database"
  @echo "  po-replace      do po-update and replace catalogs with msgmerged versions"
@@ -53,4 +53,3 @@ local-help:
  @echo "  For more information on these targets, see"
  @echo "    \`Verify regression tests' in the Contributor's Guide."
  @echo
-