Remove compat hack for Solaris7 and HP-UX (issue 579480047 by hanwenn@gmail.com)

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Remove compat hack for Solaris7 and HP-UX (issue 579480047 by hanwenn@gmail.com)

Dev mailing list
Reply | Threaded
Open this post in threaded view
|

Re: Remove compat hack for Solaris7 and HP-UX (issue 579480047 by hanwenn@gmail.com)

David Kastrup

https://codereview.appspot.com/579480047/diff/547750043/aclocal.m4
File aclocal.m4 (right):

https://codereview.appspot.com/579480047/diff/547750043/aclocal.m4#newcode694
aclocal.m4:694: AC_PATH_PROG(BASH, bash, $SHELL)
This sets BASH with a fallback to /bin/sh , meaning that $BASH is not
guaranteed to be anything remotely likely to Bash.

And in the current code base, it would not appear that $BASH is even
getting used anywhere.  At least I cannot find anything suggesting its
use  (rather than its maintenance) with

git grep BASH origin

So what is supposed to be the idea with $BASH here?  What is it supposed
to guarantee providing, and where is it supposed to (eventually?) get
used?

https://codereview.appspot.com/579480047/

Reply | Threaded
Open this post in threaded view
|

Re: Remove compat hack for Solaris7 and HP-UX (issue 579480047 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
In reply to this post by Dev mailing list
On 2020/03/15 16:47:55, dak wrote:
> https://codereview.appspot.com/579480047/diff/547750043/aclocal.m4
> File aclocal.m4 (right):
>
>
https://codereview.appspot.com/579480047/diff/547750043/aclocal.m4#newcode694
> aclocal.m4:694: AC_PATH_PROG(BASH, bash, $SHELL)
> This sets BASH with a fallback to /bin/sh , meaning that $BASH is not
guaranteed
> to be anything remotely likely to Bash.
>
> And in the current code base, it would not appear that $BASH is even
getting
> used anywhere.  At least I cannot find anything suggesting its use
(rather than
> its maintenance) with
>
> git grep BASH origin
>
> So what is supposed to be the idea with $BASH here?  What is it
supposed to
> guarantee providing, and where is it supposed to (eventually?) get
used?

I removed all things BASH for now.

We might want to consider hardcoding all our shell scripts to /bin/bash,
though.

https://codereview.appspot.com/579480047/

Reply | Threaded
Open this post in threaded view
|

Re: Remove compat hack for Solaris7 and HP-UX (issue 579480047 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
In reply to this post by Dev mailing list
commit bbc9f3a208d17670d729bfc08e4b28b0a590bf6f (origin/staging,
origin/master)
Author: Han-Wen Nienhuys <[hidden email]>
Date:   Sun Mar 15 16:08:50 2020 +0100

    Remove @BASH@.
   
    Remove compat hack for Solaris7 and HP-UX (Solaris 7 reached EOL in
    August 2008. Nobody runs HP-UX anymore.)
   
    https://sourceforge.net/p/testlilyissues/issues/5846
    http://codereview.appspot.com/579480047



https://codereview.appspot.com/579480047/