Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanwenn@gmail.com)

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanwenn@gmail.com)

jonas.hahnfeld
Sending to lilypond-devel for broader notice. This is likely to give
conflicts, maybe we can combine this with running fixcc.py?

https://codereview.appspot.com/547810043/

Reply | Threaded
Open this post in threaded view
|

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanwenn@gmail.com)

David Kastrup
On 2020/03/21 13:14:50, hahnjo wrote:
> Sending to lilypond-devel for broader notice. This is likely to give
conflicts,
> maybe we can combine this with running fixcc.py?

Ah right, that one was still pending anyway.  I think it would take care
of trailing spaces in the C++ files.

https://codereview.appspot.com/547810043/

Reply | Threaded
Open this post in threaded view
|

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanwenn@gmail.com)

David Kastrup
In reply to this post by jonas.hahnfeld
On 2020/03/21 14:17:03, dak wrote:
> On 2020/03/21 13:14:50, hahnjo wrote:
> > Sending to lilypond-devel for broader notice. This is likely to give
> conflicts,
> > maybe we can combine this with running fixcc.py?
>
> Ah right, that one was still pending anyway.  I think it would take
care of
> trailing spaces in the C++ files.

And the ones in the scm files should likely be combined with running
fixscm.sh .  I think that one warranted changing some block comments not
in Emacs convention, so I hadn't done it on stable yet.

https://codereview.appspot.com/547810043/

Reply | Threaded
Open this post in threaded view
|

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
In reply to this post by jonas.hahnfeld
On 2020/03/21 13:14:50, hahnjo wrote:
> Sending to lilypond-devel for broader notice. This is likely to give
conflicts,
> maybe we can combine this with running fixcc.py?

I've backed out scm and lily so it won't give conflicts with fixcc and
fixscm.

https://codereview.appspot.com/547810043/

Reply | Threaded
Open this post in threaded view
|

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
As discussed, will push this without countdown.

On Sat, Mar 21, 2020 at 3:36 PM <[hidden email]> wrote:

>
> On 2020/03/21 13:14:50, hahnjo wrote:
> > Sending to lilypond-devel for broader notice. This is likely to give
> conflicts,
> > maybe we can combine this with running fixcc.py?
>
> I've backed out scm and lily so it won't give conflicts with fixcc and
> fixscm.
>
> https://codereview.appspot.com/547810043/



--
Han-Wen Nienhuys - [hidden email] - http://www.xs4all.nl/~hanwen

Reply | Threaded
Open this post in threaded view
|

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanwenn@gmail.com)

jonas.hahnfeld
In reply to this post by jonas.hahnfeld
On 2020/03/21 18:20:09, hanwenn wrote:
> As discussed, will push this without countdown.

Discussed where? David proposed on lilypond-devel to run fixcc.py
tomorrow, but I see no reference to this patch.

https://codereview.appspot.com/547810043/

Reply | Threaded
Open this post in threaded view
|

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
You suggested it yourself? I removed the lily/ and scm/ changes to
avoid conflicts.

On Sat, Mar 21, 2020 at 7:38 PM <[hidden email]> wrote:
>
> On 2020/03/21 18:20:09, hanwenn wrote:
> > As discussed, will push this without countdown.
>
> Discussed where? David proposed on lilypond-devel to run fixcc.py
> tomorrow, but I see no reference to this patch.
>
> https://codereview.appspot.com/547810043/



--
Han-Wen Nienhuys - [hidden email] - http://www.xs4all.nl/~hanwen

Reply | Threaded
Open this post in threaded view
|

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanwenn@gmail.com)

jonas.hahnfeld
In reply to this post by jonas.hahnfeld
On 2020/03/21 19:09:01, hanwenn wrote:
> You suggested it yourself? I removed the lily/ and scm/ changes to
> avoid conflicts.

huh!? "maybe we can combine this with running fixcc.py?" doesn't sound
like "please push immediately"!

https://codereview.appspot.com/547810043/

Reply | Threaded
Open this post in threaded view
|

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
On Sat, Mar 21, 2020 at 8:10 PM <[hidden email]> wrote:
>
> On 2020/03/21 19:09:01, hanwenn wrote:
> > You suggested it yourself? I removed the lily/ and scm/ changes to
> > avoid conflicts.
>
> huh!? "maybe we can combine this with running fixcc.py?" doesn't sound
> like "please push immediately"!

"After a message to lilypond-devel they can probably go into staging
master directly without
much review."


https://codereview.appspot.com/549740043/#msg5

>
> https://codereview.appspot.com/547810043/



--
Han-Wen Nienhuys - [hidden email] - http://www.xs4all.nl/~hanwen

Reply | Threaded
Open this post in threaded view
|

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanwenn@gmail.com)

jonas.hahnfeld
In reply to this post by jonas.hahnfeld
On 2020/03/21 19:18:26, hanwenn wrote:
> On Sat, Mar 21, 2020 at 8:10 PM <mailto:[hidden email]>
wrote:
> >
> > On 2020/03/21 19:09:01, hanwenn wrote:
> > > You suggested it yourself? I removed the lily/ and scm/ changes to
> > > avoid conflicts.
> >
> > huh!? "maybe we can combine this with running fixcc.py?" doesn't
sound
> > like "please push immediately"!
>
> "After a message to lilypond-devel they can probably go into staging
> master directly without
> much review."

Okay, I understand how you read that statement, I'll try to be more
precise in the future. Please note that "message to lilypond-devel" for
me always means "discussion" and "asking if somebody objects". In the
case of this patch it was me who wrote the comment that it gets sent to
lilypond-devel at all (in this case asking if "we can combine this with
running fixcc.py"), I think this should be author's responsibility.

https://codereview.appspot.com/547810043/

Reply | Threaded
Open this post in threaded view
|

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
In reply to this post by jonas.hahnfeld

commit 2ddc627c3c3e0299c4dc0ba109340cff54c49710
Author: Han-Wen Nienhuys <[hidden email]>
Date:   Sat Mar 21 13:13:32 2020 +0100

    Remove trailing whitespace in {python,scripts,*make*}.



https://codereview.appspot.com/547810043/