Re: Refactor get/set_property to take the item as first argument (issue 573670043 by dak@gnu.org)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Refactor get/set_property to take the item as first argument (issue 573670043 by dak@gnu.org)

jonas.hahnfeld
So I've largely kept out of the discussion for now, mostly because I'm
not overly familiar with the code. However I fully agree with Dan that a
macro pretending to be a member function is neither obvious nor C++
style. As such I'm in favor of doing the conversion as it better meets
the expectations of average developers (at least mine).

I also agree with David that this patch doesn't prescribe any future
direction, which seems to be Han-Wen's fear. Any possible follow-up is
subject to the same review process. If there are no technical
objections, I think we should move forward and let something as big sit
around for too long.

https://codereview.appspot.com/573670043/

Reply | Threaded
Open this post in threaded view
|

Re: Refactor get/set_property to take the item as first argument (issue 573670043 by dak@gnu.org)

v.villenave
On 2020/04/24 07:20:55, hahnjo wrote:
> If there are no technical objections, I think we should move
> forward and let something as big sit around for too long.

Just for clarification, did you miss a "not" in that sentence?

Cheers,
  - V.

https://codereview.appspot.com/573670043/

Reply | Threaded
Open this post in threaded view
|

Re: Refactor get/set_property to take the item as first argument (issue 573670043 by dak@gnu.org)

jonas.hahnfeld
In reply to this post by jonas.hahnfeld
On 2020/04/24 08:15:09, Valentin Villenave wrote:
> On 2020/04/24 07:20:55, hahnjo wrote:
> > If there are no technical objections, I think we should move
> > forward and let something as big sit around for too long.
>
> Just for clarification, did you miss a "not" in that sentence?

Ehm yes. Probably past me couldn't decide where to put it...

If there are no technical objections, I think we should move
forward and not let something as big sit around for too long.

https://codereview.appspot.com/573670043/