Re: Optimize get_path_list. (issue 579570043 by hanwenn@gmail.com)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: Optimize get_path_list. (issue 579570043 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
On 2020/04/13 19:11:22, hanwenn wrote:
>
https://codereview.appspot.com/579570043/diff/577750045/lily/stencil-integral.cc
> File lily/stencil-integral.cc (right):
>
>
https://codereview.appspot.com/579570043/diff/577750045/lily/stencil-integral.cc#newcode115
> lily/stencil-integral.cc:115: && (SCM_EQ_P (head, ly_symbol2scm
("moveto"))
> On 2020/04/13 17:50:33, dak wrote:
> > SCM_EQ_P is an old deprecated macro.  Use scm_is_eq instead.  Same
> performance.
>
> Done.
>
>
https://codereview.appspot.com/579570043/diff/577750045/lily/stencil-integral.cc#newcode127
> lily/stencil-integral.cc:127: return get_path_list (scm_cdr (l));
> On 2020/04/13 17:50:33, dak wrote:
> > Not caused by this patch, but this does look like something nicer
addressed by
> a
> > loop rather than tail recursion with regard to C++ idioms.
>
> I'm gonna pass on this for now.

commit d48d79b52c28cf9c82d088b2fdf8edbf452d6f94
Author: Han-Wen Nienhuys <[hidden email]>
Date:   Mon Apr 13 18:36:46 2020 +0200

    Optimize get_path_list.
   


https://codereview.appspot.com/579570043/