Re: Issue 5561/5562: slurs work without NoteHead stencil (issue 546970043 by lilypond@maltemeyn.de)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: Issue 5561/5562: slurs work without NoteHead stencil (issue 546970043 by lilypond@maltemeyn.de)

nine.fierce.ballads

https://codereview.appspot.com/546970043/diff/552990043/lily/slur-scoring.cc
File lily/slur-scoring.cc (right):

https://codereview.appspot.com/546970043/diff/552990043/lily/slur-scoring.cc#newcode352
lily/slur-scoring.cc:352: if (!state.configurations_.size ())
It's not necessary to change this, but I encourage you to cultivate a
habit of using empty() in cases like this.  empty() is a safer default
because not all containers have an O(1) size().  empty() is also more
readable, IMO.

https://codereview.appspot.com/546970043/diff/552990043/lily/slur-scoring.cc#newcode551
lily/slur-scoring.cc:551: if (isinf (x) || isnan (x))
https://en.cppreference.com/w/cpp/numeric/math/isfinite

https://codereview.appspot.com/546970043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel