Re: Fix output-distance tests (issue 569540043 by hanwenn@gmail.com)

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Fix output-distance tests (issue 569540043 by hanwenn@gmail.com)

Dev mailing list
Just skimming the code: LGTM


https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py
File scripts/build/output-distance.py (right):

https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py#newcode66
scripts/build/output-distance.py:66: # explicitly use bash, so we don't
get dash on Ubuntu.
This needs an update of `STEPMAKE_INIT` in `aclocal.m4`.  Right now,
AFAICS, `bash` is optional, and `configure` falls back to whatever is
given in the `SHELL` environment variable.

https://codereview.appspot.com/569540043/

Reply | Threaded
Open this post in threaded view
|

Re: Fix output-distance tests (issue 569540043 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
On 2020/03/14 21:58:52, lemzwerg wrote:
> Just skimming the code: LGTM
>
>
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py
> File scripts/build/output-distance.py (right):
>
>
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py#newcode66
> scripts/build/output-distance.py:66: # explicitly use bash, so we
don't get dash
> on Ubuntu.
> This needs an update of `STEPMAKE_INIT` in `aclocal.m4`.  Right now,
AFAICS,
> `bash` is optional, and `configure` falls back to whatever is given in
the
> `SHELL` environment variable.

Are there still systems that run without bash that we care about?

I created http://codereview.appspot.com/579480047 for looking more
closely at how we configure shell.


https://codereview.appspot.com/569540043/

Reply | Threaded
Open this post in threaded view
|

Re: Fix output-distance tests (issue 569540043 by hanwenn@gmail.com)

Dev mailing list
In reply to this post by Dev mailing list
> Are there still systems that run without bash that we care about?

I guess all BSD variants might miss bash since it is evil, evil GNU
software.



https://codereview.appspot.com/569540043/

Reply | Threaded
Open this post in threaded view
|

Re: Fix output-distance tests (issue 569540043 by hanwenn@gmail.com)

David Kastrup
In reply to this post by Han-Wen Nienhuys-3
[hidden email] writes:

> On 2020/03/14 21:58:52, lemzwerg wrote:
>> Just skimming the code: LGTM
>>
>>
> https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py
>> File scripts/build/output-distance.py (right):
>>
>>
> https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py#newcode66
>> scripts/build/output-distance.py:66: # explicitly use bash, so we
> don't get dash
>> on Ubuntu.
>> This needs an update of `STEPMAKE_INIT` in `aclocal.m4`.  Right now,
> AFAICS,
>> `bash` is optional, and `configure` falls back to whatever is given in
> the
>> `SHELL` environment variable.
>
> Are there still systems that run without bash that we care about?

MacOSX, FreeBSD?

--
David Kastrup

Reply | Threaded
Open this post in threaded view
|

Re: Fix output-distance tests (issue 569540043 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
On Sun, Mar 15, 2020 at 5:10 PM David Kastrup <[hidden email]> wrote:

>
> [hidden email] writes:
>
> > On 2020/03/14 21:58:52, lemzwerg wrote:
> >> Just skimming the code: LGTM
> >>
> >>
> > https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py
> >> File scripts/build/output-distance.py (right):
> >>
> >>
> > https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py#newcode66
> >> scripts/build/output-distance.py:66: # explicitly use bash, so we
> > don't get dash
> >> on Ubuntu.
> >> This needs an update of `STEPMAKE_INIT` in `aclocal.m4`.  Right now,
> > AFAICS,
> >> `bash` is optional, and `configure` falls back to whatever is given in
> > the
> >> `SHELL` environment variable.
> >
> > Are there still systems that run without bash that we care about?
>
> MacOSX, FreeBSD?

But for compiling LilyPond you'll need to install a significant set of
dependencies (tex, metafont, bison, flex etc.). I think it is
reasonable for us to require bash as well.

also,
https://www.golem.de/news/apple-macos-wechselt-von-bash-auf-zsh-als-standard-shell-1906-141714.html
suggests that OSX actually uses bash.

--
Han-Wen Nienhuys - [hidden email] - http://www.xs4all.nl/~hanwen

Reply | Threaded
Open this post in threaded view
|

Re: Fix output-distance tests (issue 569540043 by hanwenn@gmail.com)

David Kastrup
Han-Wen Nienhuys <[hidden email]> writes:

> On Sun, Mar 15, 2020 at 5:10 PM David Kastrup <[hidden email]> wrote:
>>
>> [hidden email] writes:
>>
>> > On 2020/03/14 21:58:52, lemzwerg wrote:
>> >> Just skimming the code: LGTM
>> >>
>> >>
>> > https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py
>> >> File scripts/build/output-distance.py (right):
>> >>
>> >>
>> > https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py#newcode66
>> >> scripts/build/output-distance.py:66: # explicitly use bash, so we
>> > don't get dash
>> >> on Ubuntu.
>> >> This needs an update of `STEPMAKE_INIT` in `aclocal.m4`.  Right now,
>> > AFAICS,
>> >> `bash` is optional, and `configure` falls back to whatever is given in
>> > the
>> >> `SHELL` environment variable.
>> >
>> > Are there still systems that run without bash that we care about?
>>
>> MacOSX, FreeBSD?
>
> But for compiling LilyPond you'll need to install a significant set of
> dependencies (tex, metafont, bison, flex etc.). I think it is
> reasonable for us to require bash as well.
>
> also,
> https://www.golem.de/news/apple-macos-wechselt-von-bash-auf-zsh-als-standard-shell-1906-141714.html
> suggests that OSX actually uses bash.

Paywalled site.

Anyway, it is well-known that Apple does not use anything under GPLv3,
so if at all, they are using/offering a severely outdated version.

--
David Kastrup

Reply | Threaded
Open this post in threaded view
|

Re: Fix output-distance tests (issue 569540043 by hanwenn@gmail.com)

Dan Eble
On Mar 15, 2020, at 12:21, David Kastrup <[hidden email]> wrote:
>
> Han-Wen Nienhuys <[hidden email]> writes:
>> suggests that OSX actually uses bash.
>
> Paywalled site.

The current macOS (10.15.3, "Catalina") sets zsh as the default shell for new users.  bash is still provided.

    $ zsh --version
    zsh 5.7.1 (x86_64-apple-darwin19.0)
    $ /bin/sh --version
    GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin19)
    Copyright (C) 2007 Free Software Foundation, Inc.

Dan


Reply | Threaded
Open this post in threaded view
|

Re: Fix output-distance tests (issue 569540043 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
In reply to this post by Dev mailing list
commit fd4021a3725cda2fe41079af8208a629dda39f1a
Author: Han-Wen Nienhuys <[hidden email]>
Date:   Sat Mar 14 00:01:03 2020 +0100

    Fix output-distance tests
   


https://codereview.appspot.com/569540043/