Re: Create engravers for merging rests (issue 321930043 by horndude77@gmail.com)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Create engravers for merging rests (issue 321930043 by horndude77@gmail.com)

Thomas Morley-2
One nit. See below.
No need for a new patch-set, imho. You could change it right before
pushing.

Otherwise LGTM


https://codereview.appspot.com/321930043/diff/160001/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):

https://codereview.appspot.com/321930043/diff/160001/Documentation/notation/simultaneous.itely#newcode917
Documentation/notation/simultaneous.itely:917: parts. This can be
accomplished using the merge rests engraver.
I'd use the name, i.e. "Merge_rests_engraver"

https://codereview.appspot.com/321930043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Create engravers for merging rests (issue 321930043 by horndude77@gmail.com)

David Kastrup

https://codereview.appspot.com/321930043/diff/160001/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):

https://codereview.appspot.com/321930043/diff/160001/Documentation/notation/simultaneous.itely#newcode917
Documentation/notation/simultaneous.itely:917: parts. This can be
accomplished using the merge rests engraver.
On 2017/06/12 07:40:42, thomasmorley651 wrote:
> I'd use the name, i.e. "Merge_rests_engraver"

In that case I'd write

     using @code{Merge_rests_engraver}

namely omitting "the".

https://codereview.appspot.com/321930043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Loading...