Re: Allow slurs instead of brackets with tuplets (issue 581110043 by lemzwerg@googlemail.com)

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Allow slurs instead of brackets with tuplets (issue 581110043 by lemzwerg@googlemail.com)

Malte Meyn-3

https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slur-tweaks.ly
File input/regression/tuplet-slur-tweaks.ly (right):

https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slur-tweaks.ly#newcode1
input/regression/tuplet-slur-tweaks.ly:1: \version "2.19.55"
Shouldn’t this be 2.21.0?

https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slurs.ly
File input/regression/tuplet-slurs.ly (right):

https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slurs.ly#newcode1
input/regression/tuplet-slurs.ly:1: \version "2.19.55"
2.21.0

https://codereview.appspot.com/581110043/
_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Allow slurs instead of brackets with tuplets (issue 581110043 by lemzwerg@googlemail.com)

David Kastrup

https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slur-tweaks.ly
File input/regression/tuplet-slur-tweaks.ly (right):

https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slur-tweaks.ly#newcode1
input/regression/tuplet-slur-tweaks.ly:1: \version "2.19.55"
On 2019/10/07 14:02:46, Malte Meyn wrote:
> Shouldn’t this be 2.21.0?

Why?

https://codereview.appspot.com/581110043/
_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Allow slurs instead of brackets with tuplets (issue 581110043 by lemzwerg@googlemail.com)

Malte Meyn-3
In reply to this post by Malte Meyn-3
On 2019/10/07 15:01:56, dak wrote:

https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slur-tweaks.ly
> File input/regression/tuplet-slur-tweaks.ly (right):


https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slur-tweaks.ly#newcode1
> input/regression/tuplet-slur-tweaks.ly:1: \version "2.19.55"
> On 2019/10/07 14:02:46, Malte Meyn wrote:
> > Shouldn’t this be 2.21.0?

> Why?

IIUC the version should always be the first one which supports the
syntax and features used. Is this incorrect?

https://codereview.appspot.com/581110043/
_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Allow slurs instead of brackets with tuplets (issue 581110043 by lemzwerg@googlemail.com)

David Kastrup
[hidden email] writes:

> On 2019/10/07 15:01:56, dak wrote:
>
> https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slur-tweaks.ly
>> File input/regression/tuplet-slur-tweaks.ly (right):
>
>
> https://codereview.appspot.com/581110043/diff/569040043/input/regression/tuplet-slur-tweaks.ly#newcode1
>> input/regression/tuplet-slur-tweaks.ly:1: \version "2.19.55"
>> On 2019/10/07 14:02:46, Malte Meyn wrote:
>> > Shouldn’t this be 2.21.0?
>
>> Why?
>
> IIUC the version should always be the first one which supports the
> syntax and features used. Is this incorrect?
>
> https://codereview.appspot.com/581110043/

Syntax yes, features not necessarily.  It should be a version that
compiles (and does not produce warnings, like for non-existing
properties) so that one can compare regtests if desired.  Does this
exercise new features, or does it only change the results of existing
ones?

--
David Kastrup

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel