Patch on dynamics and \RemoveEmptyStaves

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch on dynamics and \RemoveEmptyStaves

Jean ABOU SAMRA
Hi,

I have the attached very simple patch for LilyPond. Could anyone please
guide me through the process for patch submission?

Thanks,

Jean Abou Samra



0001-Add-dynamic-interface-to-keepAliveInterfaces.patch (919 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch on dynamics and \RemoveEmptyStaves

Valentin Villenave-3
On 3/24/20, Jean Abou Samra <[hidden email]> wrote:
> I have the attached very simple patch for LilyPond. Could anyone please
> guide me through the process for patch submission?

Hi Jean,
some step-by-step instructions are available here:
http://lilypond.org/doc/latest/Documentation/contributor/quick-start.html

You may not need to use all that, but at least git and git-cl are
strongly advised.

Good luck, feel free to ask if you have any additional questions!

Cheers,
V.

Reply | Threaded
Open this post in threaded view
|

Re: Patch on dynamics and \RemoveEmptyStaves

Jean ABOU SAMRA
Hi Valentin,

How strange it sounds to write you in English.

Le 24/03/2020 à 19:24, Valentin Villenave a écrit :Hi Jean,
> some step-by-step instructions are available here:
> http://lilypond.org/doc/latest/Documentation/contributor/quick-start.html

Thanks for the pointer.

My SourceForge username is jean-abou-samra. Could someone please give me
write access to the issue tracker?

Best regards,

Jean Abou Samra


Reply | Threaded
Open this post in threaded view
|

Re[2]: Patch on dynamics and \RemoveEmptyStaves

Trevor Daniels


Hi "Jean Abou Samra", you wrote
>
>My SourceForge username is jean-abou-samra. Could someone please give me write access to the issue tracker?

Added as a Developer, with Update and Create permissions in addition to
Read.

Welcome aboard!

Trevor

Reply | Threaded
Open this post in threaded view
|

Re: Patch on dynamics and \RemoveEmptyStaves

Jean ABOU SAMRA
Hi,

Le 24/03/2020 à 23:05, Trevor a écrit :

> Hi "Jean Abou Samra", you wrote
>> My SourceForge username is jean-abou-samra. Could someone please give
>> me write access to the issue tracker?
>
> Added as a Developer, with Update and Create permissions in addition
> to Read.
>
> Welcome aboard!
>
> Trevor
Thank you!

Here is a question about updating patches using git-cl: whenever I try
to upload the patch, I get this error.


IOError: ('http error', 401, 'Unauthorized', <httplib.HTTPMessage
instance at 0x7f8715613370>)


Traceback attached. What am I doing wrong?

Best,

Jean Abou Samra


git-cl-problem.txt (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch on dynamics and \RemoveEmptyStaves

David Kastrup
Jean Abou Samra <[hidden email]> writes:

> Hi,
>
> Le 24/03/2020 à 23:05, Trevor a écrit :
>
>> Hi "Jean Abou Samra", you wrote
>>> My SourceForge username is jean-abou-samra. Could someone please
>>> give me write access to the issue tracker?
>>
>> Added as a Developer, with Update and Create permissions in addition
>> to Read.
>>
>> Welcome aboard!
>>
>> Trevor
>
> Thank you!
>
> Here is a question about updating patches using git-cl: whenever I try
> to upload the patch, I get this error.
>
>
> IOError: ('http error', 401, 'Unauthorized', <httplib.HTTPMessage
> instance at 0x7f8715613370>)
>
>
> Traceback attached. What am I doing wrong?

The question is rather what git-cl is doing wrong.  This is some fallout
from SourceForge changes (and/or our move from Google Code to there)
that nobody has gotten around to get fixed yet.

--
David Kastrup

Reply | Threaded
Open this post in threaded view
|

Re: Patch on dynamics and \RemoveEmptyStaves

pkx166h-4

On 26/03/2020 12:15, David Kastrup wrote:

> Jean Abou Samra <[hidden email]> writes:
>
>> Hi,
>>
>> Le 24/03/2020 à 23:05, Trevor a écrit :
>>
>>> Hi "Jean Abou Samra", you wrote
>>>> My SourceForge username is jean-abou-samra. Could someone please
>>>> give me write access to the issue tracker?
>>> Added as a Developer, with Update and Create permissions in addition
>>> to Read.
>>>
>>> Welcome aboard!
>>>
>>> Trevor
>> Thank you!
>>
>> Here is a question about updating patches using git-cl: whenever I try
>> to upload the patch, I get this error.
>>
>>
>> IOError: ('http error', 401, 'Unauthorized', <httplib.HTTPMessage
>> instance at 0x7f8715613370>)
>>
>>
>> Traceback attached. What am I doing wrong?
> The question is rather what git-cl is doing wrong.  This is some fallout
> from SourceForge changes (and/or our move from Google Code to there)
> that nobody has gotten around to get fixed yet.

Yes David K is correct. If someone could take a look at the scripts in
git-cl and get them working smoothly again (there are other errors
reported on this list about git-cl) it would be a boon to the dev team.


James



Reply | Threaded
Open this post in threaded view
|

Re: Patch on dynamics and \RemoveEmptyStaves

Valentin Villenave-3
On 3/26/20, James Lowe <[hidden email]> wrote:
> Yes David K is correct. If someone could take a look at the scripts in
> git-cl and get them working smoothly again (there are other errors
> reported on this list about git-cl) it would be a boon to the dev team.

By the way (this is not directly related but may orient how we decide
to address git-cl’s future), do note that git-cl will apparently
remain python2-only for the foreseeable future:
https://github.com/rietveld-codereview/rietveld/issues/486
which will become more and more of a hindrance as python 2 gets phased
out, and python 3, increasingly ubiquitous.

V.