PATCHES - Countdown for May 17th

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

PATCHES - Countdown for May 17th

James Lowe-9
Hello,

Here is the current patch countdown list. The next countdown will be on
May 19th.

A list of all merge requests can be found here:
https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority


      Push:

!32 Percent_repeat_iterator: stop gratuitous use of std::string - David
Kastrup
https://gitlab.com/lilypond/lilypond/-/merge_requests/32

!31 Lilymidy: open midi files in binary mode - Martin Neubauer
https://gitlab.com/lilypond/lilypond/-/merge_requests/31

!30 Remove break-visibility handling in tablature ties - Han-Wen Nienhuys
https://gitlab.com/lilypond/lilypond/-/merge_requests/30

!29 Comment fixes for offset_directed - David Kastrup
https://gitlab.com/lilypond/lilypond/-/merge_requests/29

!28 Resolve "Use a callback for Percent_repeat_iterator's repeat action"
- David Kastrup
https://gitlab.com/lilypond/lilypond/-/merge_requests/28

!27 Use `-dfont-ps-resdir` for make doc - Masamichi Hosoda
https://gitlab.com/lilypond/lilypond/-/merge_requests/27

!26 Split glyph contours in up/down segments for skylines - Han-Wen Nienhuys
https://gitlab.com/lilypond/lilypond/-/merge_requests/26

!24 Cache the name => index lookup in Open_type_font - Han-Wen Nienhuys
https://gitlab.com/lilypond/lilypond/-/merge_requests/24

!20 Add regtest for multiple post-events wrapper behavior - Valentin
Villenave
https://gitlab.com/lilypond/lilypond/-/merge_requests/20

!3 Add dynamic-interface to keepAliveInterfaces - Jean Abou Samra
https://gitlab.com/lilypond/lilypond/-/merge_requests/3


      Countdown:

!39 cleanup span-bar-engraver.cc - Han-Wen Nienhuys
https://gitlab.com/lilypond/lilypond/-/merge_requests/39

!22 Doc: remove now unnecessary dummy argument after lilypond
-dshow-available-fonts - Jean Abou Samra
https://gitlab.com/lilypond/lilypond/-/merge_requests/22


      Review:

!43 Fix #5234: Avoid writing a MIDI file when there is no music - Dan Eble
https://gitlab.com/lilypond/lilypond/-/merge_requests/43

!42 Resolve "(*location*) returning no valid value while parsing
embedded scheme" - David Kastrup
https://gitlab.com/lilypond/lilypond/-/merge_requests/42

!41 Issue 5129: Bad horizontal spacing when \override LyricText
#'X-offset - Kevin Barry
https://gitlab.com/lilypond/lilypond/-/merge_requests/41

!38 GNUmakefile.in: remove remove-test-changed support - Han-Wen Nienhuys
https://gitlab.com/lilypond/lilypond/-/merge_requests/38


      New:

!50 Remove some ancient long-unused cruft - David Kastrup
https://gitlab.com/lilypond/lilypond/-/merge_requests/50

!49 Remove operator= from Scheme_hash_table - Han-Wen Nienhuys
https://gitlab.com/lilypond/lilypond/-/merge_requests/49

!48 skyline: minor performance tweaks - Han-Wen Nienhuys
https://gitlab.com/lilypond/lilypond/-/merge_requests/48

!47 Stop smobifying Transform - Han-Wen Nienhuys
https://gitlab.com/lilypond/lilypond/-/merge_requests/47

!46 Clean up and fix glyph contour generation - Han-Wen Nienhuys
https://gitlab.com/lilypond/lilypond/-/merge_requests/46

!45 Remove do_break_substitution_and_fixup_refpoints() from System API -
Han-Wen Nienhuys
https://gitlab.com/lilypond/lilypond/-/merge_requests/45

!44 Change ly_chain_assoc_get to use eq? - Han-Wen Nienhuys
https://gitlab.com/lilypond/lilypond/-/merge_requests/44


      Waiting:

No patches in Waiting at this time.








*******

Regards,

James

Reply | Threaded
Open this post in threaded view
|

Re: PATCHES - Countdown for May 17th

Han-Wen Nienhuys-3
On Sun, May 17, 2020 at 9:29 AM James Lowe <[hidden email]> wrote:
>
> Hello,
>
> Here is the current patch countdown list. The next countdown will be on
> May 19th.

thanks!

What is the procedure for pushing now that we're on gitlab? Pushing to
the staging branch, or do I click a button?

>
> A list of all merge requests can be found here:
> https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority
>
>
>       Push:
>
> !32 Percent_repeat_iterator: stop gratuitous use of std::string - David
> Kastrup
> https://gitlab.com/lilypond/lilypond/-/merge_requests/32
>
> !31 Lilymidy: open midi files in binary mode - Martin Neubauer
> https://gitlab.com/lilypond/lilypond/-/merge_requests/31
>
> !30 Remove break-visibility handling in tablature ties - Han-Wen Nienhuys
> https://gitlab.com/lilypond/lilypond/-/merge_requests/30
>
> !29 Comment fixes for offset_directed - David Kastrup
> https://gitlab.com/lilypond/lilypond/-/merge_requests/29
>
> !28 Resolve "Use a callback for Percent_repeat_iterator's repeat action"
> - David Kastrup
> https://gitlab.com/lilypond/lilypond/-/merge_requests/28
>
> !27 Use `-dfont-ps-resdir` for make doc - Masamichi Hosoda
> https://gitlab.com/lilypond/lilypond/-/merge_requests/27
>
> !26 Split glyph contours in up/down segments for skylines - Han-Wen Nienhuys
> https://gitlab.com/lilypond/lilypond/-/merge_requests/26
>
> !24 Cache the name => index lookup in Open_type_font - Han-Wen Nienhuys
> https://gitlab.com/lilypond/lilypond/-/merge_requests/24
>
> !20 Add regtest for multiple post-events wrapper behavior - Valentin
> Villenave
> https://gitlab.com/lilypond/lilypond/-/merge_requests/20
>
> !3 Add dynamic-interface to keepAliveInterfaces - Jean Abou Samra
> https://gitlab.com/lilypond/lilypond/-/merge_requests/3
>
>
>       Countdown:
>
> !39 cleanup span-bar-engraver.cc - Han-Wen Nienhuys
> https://gitlab.com/lilypond/lilypond/-/merge_requests/39
>
> !22 Doc: remove now unnecessary dummy argument after lilypond
> -dshow-available-fonts - Jean Abou Samra
> https://gitlab.com/lilypond/lilypond/-/merge_requests/22
>
>
>       Review:
>
> !43 Fix #5234: Avoid writing a MIDI file when there is no music - Dan Eble
> https://gitlab.com/lilypond/lilypond/-/merge_requests/43
>
> !42 Resolve "(*location*) returning no valid value while parsing
> embedded scheme" - David Kastrup
> https://gitlab.com/lilypond/lilypond/-/merge_requests/42
>
> !41 Issue 5129: Bad horizontal spacing when \override LyricText
> #'X-offset - Kevin Barry
> https://gitlab.com/lilypond/lilypond/-/merge_requests/41
>
> !38 GNUmakefile.in: remove remove-test-changed support - Han-Wen Nienhuys
> https://gitlab.com/lilypond/lilypond/-/merge_requests/38
>
>
>       New:
>
> !50 Remove some ancient long-unused cruft - David Kastrup
> https://gitlab.com/lilypond/lilypond/-/merge_requests/50
>
> !49 Remove operator= from Scheme_hash_table - Han-Wen Nienhuys
> https://gitlab.com/lilypond/lilypond/-/merge_requests/49
>
> !48 skyline: minor performance tweaks - Han-Wen Nienhuys
> https://gitlab.com/lilypond/lilypond/-/merge_requests/48
>
> !47 Stop smobifying Transform - Han-Wen Nienhuys
> https://gitlab.com/lilypond/lilypond/-/merge_requests/47
>
> !46 Clean up and fix glyph contour generation - Han-Wen Nienhuys
> https://gitlab.com/lilypond/lilypond/-/merge_requests/46
>
> !45 Remove do_break_substitution_and_fixup_refpoints() from System API -
> Han-Wen Nienhuys
> https://gitlab.com/lilypond/lilypond/-/merge_requests/45
>
> !44 Change ly_chain_assoc_get to use eq? - Han-Wen Nienhuys
> https://gitlab.com/lilypond/lilypond/-/merge_requests/44
>
>
>       Waiting:
>
> No patches in Waiting at this time.
>
>
>
>
>
>
>
>
> *******
>
> Regards,
>
> James
>


--
Han-Wen Nienhuys - [hidden email] - http://www.xs4all.nl/~hanwen

Reply | Threaded
Open this post in threaded view
|

Re: PATCHES - Countdown for May 17th

James Lowe-9
On 17/05/2020 08:38, Han-Wen Nienhuys wrote:

> On Sun, May 17, 2020 at 9:29 AM James Lowe<[hidden email]>  wrote:
>> Hello,
>>
>> Here is the current patch countdown list. The next countdown will be on
>> May 19th.
> thanks!
>
> What is the procedure for pushing now that we're on gitlab? Pushing to
> the staging branch, or do I click a button?
>
To be honest, I am still unsure (but I only have to care about updating
merge requests).

However, see the thread from the last countdown.

It starts here

https://lists.gnu.org/archive/html/lilypond-devel/2020-05/msg00359.html

James

Reply | Threaded
Open this post in threaded view
|

Re: PATCHES - Countdown for May 17th

David Kastrup
James Lowe <[hidden email]> writes:

> On 17/05/2020 08:38, Han-Wen Nienhuys wrote:
>> On Sun, May 17, 2020 at 9:29 AM James Lowe<[hidden email]>  wrote:
>>> Hello,
>>>
>>> Here is the current patch countdown list. The next countdown will be on
>>> May 19th.
>> thanks!
>>
>> What is the procedure for pushing now that we're on gitlab? Pushing to
>> the staging branch, or do I click a button?
>>
> To be honest, I am still unsure (but I only have to care about
> updating merge requests).
>
> However, see the thread from the last countdown.
>
> It starts here
>
> https://lists.gnu.org/archive/html/lilypond-devel/2020-05/msg00359.html

I think for now it's pushing to staging.  Either from the command line,
or because you have set staging as your destination branch in the GUI,
in which case you can use a button (usually starting by rebase).

--
David Kastrup

Reply | Threaded
Open this post in threaded view
|

Re: PATCHES - Countdown for May 17th

Jonas Hahnfeld
Am Sonntag, den 17.05.2020, 14:29 +0200 schrieb David Kastrup:

> James Lowe <[hidden email]> writes:
>
> > On 17/05/2020 08:38, Han-Wen Nienhuys wrote:
> > > On Sun, May 17, 2020 at 9:29 AM James Lowe<[hidden email]>  wrote:
> > > > Hello,
> > > >
> > > > Here is the current patch countdown list. The next countdown will be on
> > > > May 19th.
> > >
> > > thanks!
> > >
> > > What is the procedure for pushing now that we're on gitlab? Pushing to
> > > the staging branch, or do I click a button?
> > >
> >
> > To be honest, I am still unsure (but I only have to care about
> > updating merge requests).
> >
> > However, see the thread from the last countdown.
> >
> > It starts here
> >
> > https://lists.gnu.org/archive/html/lilypond-devel/2020-05/msg00359.html
> >
>
> I think for now it's pushing to staging.  Either from the command line,
> or because you have set staging as your destination branch in the GUI,
> in which case you can use a button (usually starting by rebase).
If using the command line, just make sure to push the rebased commit to
the merge request first so that GitLab marks it correctly. I haven't
found a way to set the "merged" state manually after the commits have
hit staging...

Jonas

signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: PATCHES - Countdown for May 17th

Werner LEMBERG
>> I think for now it's pushing to staging.  Either from the command
>> line, or because you have set staging as your destination branch in
>> the GUI, in which case you can use a button (usually starting by
>> rebase).
>
> If using the command line, just make sure to push the rebased commit
> to the merge request first so that GitLab marks it correctly.  I
> haven't found a way to set the "merged" state manually after the
> commits have hit staging...

It seems we should provide a small script 'lilypond-commit', to be
used by everyone...


    Werner

Reply | Threaded
Open this post in threaded view
|

Re: PATCHES - Countdown for May 17th

David Kastrup
Werner LEMBERG <[hidden email]> writes:

>>> I think for now it's pushing to staging.  Either from the command
>>> line, or because you have set staging as your destination branch in
>>> the GUI, in which case you can use a button (usually starting by
>>> rebase).
>>
>> If using the command line, just make sure to push the rebased commit
>> to the merge request first so that GitLab marks it correctly.  I
>> haven't found a way to set the "merged" state manually after the
>> commits have hit staging...
>
> It seems we should provide a small script 'lilypond-commit', to be
> used by everyone...

There are a few small scripts on the agenda...  It turns out that one
can achieve a whole lot just using git commands (like with git push
options) without even needing to consult a Gitlab API.  Together with
conventions for branch/tag naming, there is a lot of potential to
achieve similar functionality to what we once did with git-cl with much
much less code and work since basically all of the transport of
information can be done using the git command line.

--
David Kastrup

Reply | Threaded
Open this post in threaded view
|

Re: PATCHES - Countdown for May 17th

Jonas Hahnfeld
In reply to this post by Werner LEMBERG
Am Sonntag, den 17.05.2020, 15:18 +0200 schrieb Werner LEMBERG:

> >> I think for now it's pushing to staging.  Either from the command
> >> line, or because you have set staging as your destination branch in
> >> the GUI, in which case you can use a button (usually starting by
> >> rebase).
> >
> > If using the command line, just make sure to push the rebased commit
> > to the merge request first so that GitLab marks it correctly.  I
> > haven't found a way to set the "merged" state manually after the
> > commits have hit staging...
>
> It seems we should provide a small script 'lilypond-commit', to be
> used by everyone...
Just use the UI to merge. This will probably become mandatory when
integrating CI which I'm preparing right now.

Jonas

signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: PATCHES - Countdown for May 17th

David Kastrup
Jonas Hahnfeld <[hidden email]> writes:

> Am Sonntag, den 17.05.2020, 15:18 +0200 schrieb Werner LEMBERG:
>> >> I think for now it's pushing to staging.  Either from the command
>> >> line, or because you have set staging as your destination branch in
>> >> the GUI, in which case you can use a button (usually starting by
>> >> rebase).
>> >
>> > If using the command line, just make sure to push the rebased commit
>> > to the merge request first so that GitLab marks it correctly.  I
>> > haven't found a way to set the "merged" state manually after the
>> > commits have hit staging...
>>
>> It seems we should provide a small script 'lilypond-commit', to be
>> used by everyone...
>
> Just use the UI to merge. This will probably become mandatory when
> integrating CI which I'm preparing right now.

It is much more direct to manage one's commits/issues on the command
line.  We should not lightly forego that possibility.

--
David Kastrup

Reply | Threaded
Open this post in threaded view
|

Re: PATCHES - Countdown for May 17th

Jonas Hahnfeld
Am Sonntag, den 17.05.2020, 15:50 +0200 schrieb David Kastrup:

> Jonas Hahnfeld <[hidden email]> writes:
> > Am Sonntag, den 17.05.2020, 15:18 +0200 schrieb Werner LEMBERG:
> > > > > I think for now it's pushing to staging.  Either from the command
> > > > > line, or because you have set staging as your destination branch in
> > > > > the GUI, in which case you can use a button (usually starting by
> > > > > rebase).
> > > >
> > > > If using the command line, just make sure to push the rebased commit
> > > > to the merge request first so that GitLab marks it correctly.  I
> > > > haven't found a way to set the "merged" state manually after the
> > > > commits have hit staging...
> > >
> > > It seems we should provide a small script 'lilypond-commit', to be
> > > used by everyone...
> >
> > Just use the UI to merge. This will probably become mandatory when
> > integrating CI which I'm preparing right now.
>
> It is much more direct to manage one's commits/issues on the command
> line.  We should not lightly forego that possibility.
I agree for editing commit messages and more complex rebases, but
merging should be left to an entity that enforces policy. Right now
this is patchy pushing from staging to master. In my book, this should
be GitLab when it has CI information.

signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: PATCHES - Countdown for May 17th

Jonas Hahnfeld
In reply to this post by Jonas Hahnfeld
Am Sonntag, den 17.05.2020, 15:41 +0200 schrieb Jonas Hahnfeld:

> Am Sonntag, den 17.05.2020, 15:18 +0200 schrieb Werner LEMBERG:
> > > > I think for now it's pushing to staging.  Either from the command
> > > > line, or because you have set staging as your destination branch in
> > > > the GUI, in which case you can use a button (usually starting by
> > > > rebase).
> > >
> > > If using the command line, just make sure to push the rebased commit
> > > to the merge request first so that GitLab marks it correctly.  I
> > > haven't found a way to set the "merged" state manually after the
> > > commits have hit staging...
> >
> > It seems we should provide a small script 'lilypond-commit', to be
> > used by everyone...
>
> Just use the UI to merge. This will probably become mandatory when
> integrating CI which I'm preparing right now.
Another benefit of merging via the UI is that it automatically deletes
the source branch (unless you unticked the box when creating the merge
request).

signature.asc (499 bytes) Download Attachment