Make dblatex an optional dependency (issue 567480043 by jonas.hahnfeld@gmail.com)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Make dblatex an optional dependency (issue 567480043 by jonas.hahnfeld@gmail.com)

jonas.hahnfeld
Reviewers: ,

Message:
For some context: I played with the Docker containers shared by Han-Wen.
The one based on Ubuntu 16.04 (Xenial) is 974MB in size. Removing things
like git, nano, gdb and additional fonts (when purely interested in
automated building) gets me down to 809MB. Of the remaining, dblatex
seems to be one of the larger dependencies because it pulls in much of
TeXlive. After removing the image only weighs 667MB.

Given that it is used only for compiling a single test produced by
lilypond-book (nothing that ever shows up in the uploaded
documentation), I would also be happy to drop the dependency entirely.
The lost coverage amounts to not checking that the produced .xml file
can be processed by dblatex...

Description:
Make dblatex an optional dependency

Commit cfa910f1c1 in 2012 made it required unless disabling the doc
build. This is an overapproximation since dblatex is only required
for compiling the DocBook result of running lilypond-book on the file
input/regression/lilypond-book/suffix-lyxml.lyxml. If unavailable the
rules in make/lilypond-book-*.make have checks to only produce the
intermediate .xml file, without running dblatex to produce a .pdf.

Please review this at https://codereview.appspot.com/567480043/

Affected files (+1, -1 lines):
  M configure.ac


Index: configure.ac
diff --git a/configure.ac b/configure.ac
index 05b868afe8fc1eef782b5a827df49965e6b81730..162d7e60904450d22c0ae1aa21fd88603a20a249 100644
--- a/configure.ac
+++ b/configure.ac
@@ -372,7 +372,7 @@ fi
 
 STEPMAKE_PROGS(MAKEINFO, makeinfo, REQUIRED, 6.1)
 STEPMAKE_PROGS(TEXI2HTML, texi2html, $DOCUMENTATION_REQUIRED, 1.82, 1.82)
-STEPMAKE_PROGS(DBLATEX, dblatex, $DOCUMENTATION_REQUIRED, 0.1.4)
+STEPMAKE_PROGS(DBLATEX, dblatex, OPTIONAL, 0.1.4)
 STEPMAKE_PROGS(BIBTEX, bibtex, $DOCUMENTATION_REQUIRED)
 STEPMAKE_PROGS(PDFLATEX, xelatex pdflatex, $DOCUMENTATION_REQUIRED)
 if test "$PDFLATEX" = "xelatex"; then



Reply | Threaded
Open this post in threaded view
|

Re: Make dblatex an optional dependency (issue 567480043 by jonas.hahnfeld@gmail.com)

Dev mailing list