Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by email@example.com)
Regtest differences attached to the ticket are expected. I would
appreciate independent confirmation; is anyone interested in taking a
little time to understand the case? After that, I think it will make
sense to push this, since the code was reviewed last week and is just
enabled by this patch.
- // TODO: Enabling this block will fix input/regression/context-find-parent.ly.
- if (false && allow_find && (dir == CENTER))
+ if (allow_find && (dir == CENTER))
// Search everything in and below the scope of the current context first.
// Here is an example that depends on finding a context below.
> nit: please use the commit SHA1 for referencing previous code. It is
> self-contained, and doesn't need the internet for understanding the
For referencing previous issues, we have so far used the issue number,
so that would be rather something to discuss on the list rather than as
a side note.
We have been able to transport the issue database across several
different systems, so the issue numbers have proven a comparatively
workable reference frame. Commit ids work just in Git.
For information strictly related to a single commit, like when reverting
a commit, a commit id is certainly a good reference but at least in the
case of reverts, the issue number contained in the original commit
message is also present.
In addition, issue numbers tend to be associated with reports showing
the history and rationale behind a change and often giving extensive
other information like problem images. That's something we cannot
attach to commits (or at least, this has not been attempted so far).
> > nit: please use the commit SHA1 for referencing previous code. It is
> > self-contained, and doesn't need the internet for understanding the
> > context.
> For referencing previous issues, we have so far used the issue number,
> so that would be rather something to discuss on the list rather than as
> a side note.
I'll do that.