Implementing Chord Semantics as a part of the EventChord structure, (issue 321250043 by chazwins6@gmail.com)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Implementing Chord Semantics as a part of the EventChord structure, (issue 321250043 by chazwins6@gmail.com)

nine.fierce.ballads
I reviewed the C++ file.  I believe others are more qualified to review
the patch as a whole.


https://codereview.appspot.com/321250043/diff/1/lily/chord-name-engraver.cc
File lily/chord-name-engraver.cc (right):

https://codereview.appspot.com/321250043/diff/1/lily/chord-name-engraver.cc#newcode99
lily/chord-name-engraver.cc:99: SCM name_proc = get_property
("chordSemanticsNameFunction");
1. Should chordSemanticsNameFunction be included in the list at the
bottom of this file? (I think so.)
2. Does the type of name_proc need to be validated before passing it to
scm_call_2? (I really don't remember.)

https://codereview.appspot.com/321250043/diff/1/lily/chord-name-engraver.cc#newcode103
lily/chord-name-engraver.cc:103: // Ugh, we created a grob, now we
better populate it.
If this was not expected, then as a user, I would like to see lilypond
emit a warning.

https://codereview.appspot.com/321250043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Implementing Chord Semantics as a part of the EventChord structure, (issue 321250043 by chazwins6@gmail.com)

pkx166h
I've created a tracker issue for this so that it gets entered into the
patch cycle proper.

https://sourceforge.net/p/testlilyissues/issues/5153/

Charles I also see that you have rights to update trackers, so you will
also get notifications from this as it goes through the review process.

https://codereview.appspot.com/321250043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel