Fix portuguese in all copies of utf-8.ly (issue 571640044 by hanwenn@gmail.com)

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Fix portuguese in all copies of utf-8.ly (issue 571640044 by hanwenn@gmail.com)

Dev mailing list
LGTM – you definitely know how to speak that language :-)

https://codereview.appspot.com/571640044/

Reply | Threaded
Open this post in threaded view
|

Re: Fix portuguese in all copies of utf-8.ly (issue 571640044 by hanwenn@gmail.com)

Thomas Morley-2

https://codereview.appspot.com/571640044/diff/571650043/Documentation/snippets/utf-8.ly
File Documentation/snippets/utf-8.ly (right):

https://codereview.appspot.com/571640044/diff/571650043/Documentation/snippets/utf-8.ly#newcode1
Documentation/snippets/utf-8.ly:1: % DO NOT EDIT this file manually; it
is automatically
Makes no sense to fix this snippet here.
It is superseded  by the snippet in Documentation/snippets/new.
Furthermore next LSR-import would override it again.
Thus the fix should be done in LSR.

Alas, LSR seems down, atm...

https://codereview.appspot.com/571640044/

Reply | Threaded
Open this post in threaded view
|

Re: Fix portuguese in all copies of utf-8.ly (issue 571640044 by hanwenn@gmail.com)

Thomas Morley-2
In reply to this post by Dev mailing list
On 2020/02/15 21:41:57, thomasmorley651 wrote:
>
https://codereview.appspot.com/571640044/diff/571650043/Documentation/snippets/utf-8.ly
> File Documentation/snippets/utf-8.ly (right):
>
>
https://codereview.appspot.com/571640044/diff/571650043/Documentation/snippets/utf-8.ly#newcode1
> Documentation/snippets/utf-8.ly:1: % DO NOT EDIT this file manually;
it is
> automatically
> Makes no sense to fix this snippet here.
> It is superseded  by the snippet in Documentation/snippets/new.
> Furthermore next LSR-import would override it again.
> Thus the fix should be done in LSR.
>
> Alas, LSR seems down, atm...

LSR is up again.
Though, I'm puzzled how characters are displayed. I feel unable to fix
it.

Werner, may I ask you to have a look?

https://codereview.appspot.com/571640044/

Reply | Threaded
Open this post in threaded view
|

Re: Fix portuguese in all copies of utf-8.ly (issue 571640044 by hanwenn@gmail.com)

Dev mailing list
In reply to this post by Dev mailing list
> Werner, may I ask you to have a look?

What exactly shall I check?

https://codereview.appspot.com/571640044/

Reply | Threaded
Open this post in threaded view
|

Re: Fix portuguese in all copies of utf-8.ly (issue 571640044 by hanwenn@gmail.com)

Thomas Morley-2
In reply to this post by Dev mailing list
On 2020/02/18 07:39:45, lemzwerg wrote:
> > Werner, may I ask you to have a look?
>
> What exactly shall I check?

If you look at
https://lsr.di.unimi.it/form.php?type=snippet;id=600;rld=m_snippet
you'll see:

portuguese = \lyricmode {
  à  vo -- cê uma can -- ção legal
}

I don't know how to change it, so that
http://lsr.di.unimi.it/LSR/Snippet?id=600
shows the same as in Han-Wen's patch here.


https://codereview.appspot.com/571640044/

Reply | Threaded
Open this post in threaded view
|

Re: Fix portuguese in all copies of utf-8.ly (issue 571640044 by hanwenn@gmail.com)

Dev mailing list
In reply to this post by Dev mailing list
>   à  vo -- cê uma can -- ção legal
>
> I don't know how to change it, so that
> http://lsr.di.unimi.it/LSR/Snippet?id=600
> shows the same as in Han-Wen's patch here.

This seems to be a bug on LSR webpage: What you see is double-encoded
UTF-8 (see
https://stackoverflow.com/questions/11436594/how-to-fix-double-encoded-utf8-characters-in-an-utf-8-table
for a similar mysql issue) – UTF-8 encoded characters get interpreted as
Latin-1, which in turn get re-interpreted as UTF-8.

Note that in the LSR database itself the problem doesn't happen.

Please contact Sebastiano so that he can comment and probably implement
a fix.


https://codereview.appspot.com/571640044/

Reply | Threaded
Open this post in threaded view
|

Re: Fix portuguese in all copies of utf-8.ly (issue 571640044 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
In reply to this post by Dev mailing list
commit 05436545bbfc905bd72eff258fb6583591ebd3c3
Author: Han-Wen Nienhuys <[hidden email]>
Date:   Sat Feb 15 13:22:59 2020 +0100

    Fix portuguese in input/regression/utf-8.ly
   
    https://sourceforge.net/p/testlilyissues/issues/5765
    http://codereview.appspot.com/571640044



https://codereview.appspot.com/571640044/