Doc: CG - Minor updates to 3.4.9 - Commit access (issue 566540043 by pkxgnugitcl@runbox.com)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Doc: CG - Minor updates to 3.4.9 - Commit access (issue 566540043 by pkxgnugitcl@runbox.com)

Thomas Morley-2
It's too long I had to follow those lines, thus I can't say anything to
your changes.

One nit:


https://codereview.appspot.com/566540043/diff/566530044/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):

https://codereview.appspot.com/566540043/diff/566530044/Documentation/contributor/source-code.itexi#newcode2078
Documentation/contributor/source-code.itexi:2078: The the GNOME desktop
will usually store the passphrase for an entire
one "the" too much

https://codereview.appspot.com/566540043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Doc: CG - Minor updates to 3.4.9 - Commit access (issue 566540043 by pkxgnugitcl@runbox.com)

Federico Bruni
I guess that most GNOME users nowadays use version 3, so we should use
the gsettings command instead of GConf.


https://codereview.appspot.com/566540043/diff/566530044/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):

https://codereview.appspot.com/566540043/diff/566530044/Documentation/contributor/source-code.itexi#newcode2086
Documentation/contributor/source-code.itexi:2086:
GConf has been replaced by gsettings/Dconf in GNOME 3, which is now
quite mature. The correct schema to set in GNOME 3 is
org.gnome.crypto.cache.

Some examples:

$ gsettings list-keys org.gnome.crypto.cache
gpg-cache-method
gpg-cache-ttl

$ gsettings get org.gnome.crypto.cache gpg-cache-method
'session'

$ gsettings describe org.gnome.crypto.cache gpg-cache-method
The method to use for caching passphrases typed into the GPG agent.
Should be one of: 'always' caches permanently, 'session' caches until
session end, 'idle' caches until the not used for gpg-cache-ttl seconds,
'timeout' caches until gpg-cache-ttl seconds.

You may keep the gconftool-2 command and say that it's specific of GNOME
2.

https://codereview.appspot.com/566540043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reply | Threaded
Open this post in threaded view
|

Re: Doc: CG - Minor updates to 3.4.9 - Commit access (issue 566540043 by pkxgnugitcl@runbox.com)

John Mandereau-2
In reply to this post by Thomas Morley-2
This looks good to me, except a phrasing nitpick.


https://codereview.appspot.com/566540043/diff/566530044/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):

https://codereview.appspot.com/566540043/diff/566530044/Documentation/contributor/source-code.itexi#newcode2217
Documentation/contributor/source-code.itexi:2217: @warning{Never push
directly to master always push to staging.  See
It sounds to me that something is missing between "master" and "always",
at least some punctuation like a comma or a semi-colon.

https://codereview.appspot.com/566540043/

_______________________________________________
lilypond-devel mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/lilypond-devel