Could not find ottavation markup

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Could not find ottavation markup

Dan Eble
Using the latest version of master, I'm seeing the warning "Could not find ottavation markup for 1 octaves up" in a number of my scores when MIDI output is enabled.  This warning was added about a year ago in commit 476194c706e4f9898fdbd5847dc1a924843f03e8 for Issue 5559.

How should this be addressed?  I can think of a few alternatives.

* define the markup in performer init (seems wrong)
* remove the warning
* before issuing the warning, check another property
  like in ab4f3cd2ad792b848c1045fd572b5f119a180d23

I lean toward removing the warning.

Dan

\version "2.20.0"
\score {
 \fixed c' { \ottava #1 c1 }
 \midi { }
}
Reply | Threaded
Open this post in threaded view
|

Re: Could not find ottavation markup

Michael Käppler-2
Am 29.09.2020 um 14:38 schrieb Dan Eble:

> Using the latest version of master, I'm seeing the warning "Could not find ottavation markup for 1 octaves up" in a number of my scores when MIDI output is enabled.  This warning was added about a year ago in commit 476194c706e4f9898fdbd5847dc1a924843f03e8 for Issue 5559.
>
> How should this be addressed?  I can think of a few alternatives.
>
> * define the markup in performer init (seems wrong)
> * remove the warning
> * before issuing the warning, check another property
>    like in ab4f3cd2ad792b848c1045fd572b5f119a180d23
>
> I lean toward removing the warning.
Hi Dan,
what about this: (only tested with your MWE, though)

diff --git a/scm/define-music-callbacks.scm b/scm/define-music-callbacks.scm
index 2d1bb97657..01d1c89854 100644
--- a/scm/define-music-callbacks.scm
+++ b/scm/define-music-callbacks.scm
@@ -83,6 +83,7 @@ to be used by the sequential-iterator"
                  (set! (ly:context-property context 'middleCOffset) offset)
                  (set! (ly:context-property context 'ottavation)
ottavation-markup)
                  (if (and (not (zero? octavation))
+                         (not (null? markups))
                           (not (markup? ottavation-markup)))
                      (ly:warning "Could not find ottavation markup for
~a octaves up." octavation))
                  (ly:set-middle-C! context))))

Cheers,
Michael


Reply | Threaded
Open this post in threaded view
|

Re: Could not find ottavation markup

Dan Eble
On Sep 30, 2020, at 15:56, Michael Käppler <[hidden email]> wrote:
>
> Am 29.09.2020 um 14:38 schrieb Dan Eble:
...
>> I lean toward removing the warning.
> Hi Dan,
> what about this: (only tested with your MWE, though)

Thanks & LGTM.  Are you willing to put that in a merge request?

Dan


Reply | Threaded
Open this post in threaded view
|

Re: Could not find ottavation markup

Michael Käppler-2
Am 01.10.2020 um 00:23 schrieb Dan Eble:
> On Sep 30, 2020, at 15:56, Michael Käppler <[hidden email]> wrote:
>> Am 29.09.2020 um 14:38 schrieb Dan Eble:
> ...
>>> I lean toward removing the warning.
>> Hi Dan,
>> what about this: (only tested with your MWE, though)
> Thanks & LGTM.  Are you willing to put that in a merge request?
> —
> Dan
Yes, will do that today.

Michael