Cleanup flower/ makefile (issue 577700045 by hanwenn@gmail.com)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Cleanup flower/ makefile (issue 577700045 by hanwenn@gmail.com)

Dev mailing list
LGTM, with nits.


https://codereview.appspot.com/577700045/diff/547810068/flower/GNUmakefile
File flower/GNUmakefile (right):

https://codereview.appspot.com/577700045/diff/547810068/flower/GNUmakefile#newcode17
flower/GNUmakefile:17: TEST_LOADLIBES = $(LIBRARY) $(CXXABI_LIBS)
I suggest s/TEST_LOADLIBES/TEST_LOADLIBS/.

https://codereview.appspot.com/577700045/diff/547810068/flower/GNUmakefile#newcode33
flower/GNUmakefile:33: AR=ar
s/AR=ar/AR = ar/ for consistency.

Irrespective of that I wonder why setting `AR` is necessary at all since
the configure script sets this variable (via the `STEPMAKE_LIB` macro) –
it seems to make that it won't work with cross-compiling.

https://codereview.appspot.com/577700045/