Announce end of multi-measure-rest (issue 561310045 by hanwenn@gmail.com)

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Announce end of multi-measure-rest (issue 561310045 by hanwenn@gmail.com)

Dev mailing list
Would be nice to have a regtest so that there is an example how to use
it.

https://codereview.appspot.com/561310045/

Reply | Threaded
Open this post in threaded view
|

Re: Announce end of multi-measure-rest (issue 561310045 by hanwenn@gmail.com)

nine.fierce.ballads
On 2020/01/24 17:58:44, lemzwerg wrote:
> Would be nice to have a regtest so that there is an example how to use
it.

+1

https://codereview.appspot.com/561310045/

Reply | Threaded
Open this post in threaded view
|

Re: Announce end of multi-measure-rest (issue 561310045 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
In reply to this post by Dev mailing list
Reviewers: lemzwerg, Dan Eble,

Message:
That's for anoter change. I thought that I should do
https://codereview.appspot.com/553400043/ as a scheme engraver, but
maybe it's more something for OLL ?

Description:
Announce end of multi-measure-rest

This will allow certain user-defined engravers to do useful things

Please review this at https://codereview.appspot.com/561310045/

Affected files (+2, -0 lines):
  M lily/multi-measure-rest-engraver.cc


Index: lily/multi-measure-rest-engraver.cc
diff --git a/lily/multi-measure-rest-engraver.cc b/lily/multi-measure-rest-engraver.cc
index 017d01ca134eeb8255f2b3157d7de4c45e2fb485..3e95806e6422d1741bf04c4798ab59e48d1f291e 100644
--- a/lily/multi-measure-rest-engraver.cc
+++ b/lily/multi-measure-rest-engraver.cc
@@ -242,6 +242,8 @@ Multi_measure_rest_engraver::process_music ()
           set_measure_count (curr_measure - start_measure_);
           if (last_command_item_)
             add_bound_item_to_grobs (last_command_item_);
+
+          announce_end_grob(mmrest_, SCM_EOL);
           reset_grobs ();
         }
     }



Reply | Threaded
Open this post in threaded view
|

Re: Announce end of multi-measure-rest (issue 561310045 by hanwenn@gmail.com)

Dev mailing list
In reply to this post by Dev mailing list
On 2020/01/24 18:40:56, hanwenn wrote:
> That's for anoter change. I thought that I should do
> https://codereview.appspot.com/553400043/ as a scheme engraver, but
maybe it's
> more something for OLL ?

Whatever - I created
https://sourceforge.net/p/testlilyissues/issues/5708/ so it isn't
forgotten.

https://codereview.appspot.com/561310045/

Reply | Threaded
Open this post in threaded view
|

Re: Announce end of multi-measure-rest (issue 561310045 by hanwenn@gmail.com)

Han-Wen Nienhuys-3
In reply to this post by Dev mailing list
Reply | Threaded
Open this post in threaded view
|

Re: Announce end of multi-measure-rest (issue 561310045 by hanwenn@gmail.com)

pkx166h-4
Hello,

On 29/01/2020 05:59, [hidden email] wrote:
> ping?
>
> https://codereview.appspot.com/561310045/
>
There's no need to do this really. That was kind of the point of the
countdown method we have.

The devs get (essentially) 5 - 7 days to see 2 emails for all issues
that need looking at. While some do a LGTM, there was some assumption
that instead of filling up the reviews with +1/LGTM etc. That as long as
it passed tests and went through the countdown
(new/review/countdown/push) without complaint it was taken as read the
patch was OK.

If a dev wants to keep a patch on review longer then set the Tracker
back to whatever you need (i.e. put it back from countdown to review)
and I'll just move it on one again the next time.

It saves polluting the reviews.

James


Reply | Threaded
Open this post in threaded view
|

Re: Announce end of multi-measure-rest (issue 561310045 by hanwenn@gmail.com)

Carl Sorensen-3
In reply to this post by Han-Wen Nienhuys-3
LGTM.

Excuse my Phone spellcheck

________________________________
From: lilypond-devel <lilypond-devel-bounces+c_sorensen=[hidden email]> on behalf of [hidden email] <[hidden email]>
Sent: Tuesday, January 28, 2020 10:59:08 PM
To: [hidden email] <[hidden email]>; [hidden email] <[hidden email]>; [hidden email] <[hidden email]>
Cc: [hidden email] <[hidden email]>; [hidden email] <[hidden email]>
Subject: Re: Announce end of multi-measure-rest (issue 561310045 by [hidden email])

ping?

https://codereview.appspot.com/561310045/